All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Leonardo E. Reiter" <lreiter@win4lin.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Patch] Kqemu patch for 2.6.17-rc2
Date: Tue, 06 Jun 2006 10:15:46 -0400	[thread overview]
Message-ID: <44858E12.2030803@win4lin.com> (raw)
In-Reply-To: <20060510234101.55cb336b@crazy.kos.nx>

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

Hi,

I'm attaching a small update to Thomas's patch which conditionally 
enables this based on kernel version.  As far as I can tell (from very 
brief research), module_param became available very late in 2.4.  Also, 
the old version (MODULE_PARM) is supported in most 2.6 kernels as well. 
  I picked arbitrarily 2.6.10 as the break-off point - it's really easy 
to change that to be something else.  In any case, Fabrice, can you 
think about applying this, or something very similar, as it looks like 
MODULE_PARM has been finally abandoned in the latest kernels.

Regards,

Leo Reiter

Thomas Petazzoni wrote:
> Hi,
> 
> On 2.6.17-rc2, the MODULE_PARM() way of declaring module parameters
> seems to have disappeared (it is anyway deprecated since the beginning
> of the 2.6 series). As such, kqemu-1.3.0pre7 doesn't compile.

-- 
Leonardo E. Reiter
Vice President of Product Development, CTO

Win4Lin, Inc.
Virtual Computing that means Business
Main: +1 512 339 7979
Fax: +1 512 532 6501
http://www.win4lin.com

[-- Attachment #2: kqemu-linux-module-param.diff --]
[-- Type: text/x-patch, Size: 489 bytes --]

--- kqemu-linux.c.orig	2006-06-06 10:06:03.000000000 -0400
+++ kqemu-linux.c	2006-06-06 10:09:41.000000000 -0400
@@ -49,7 +49,11 @@
 /* if 0 is used, then devfs/udev is used to automatically create the
    device */
 int major = 250;
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,10)
 MODULE_PARM(major,"i");
+#else
+module_param(major, int, 0);
+#endif
 
 /* Lock the page at virtual address 'user_addr' and return its
    physical address (page index). Return a host OS private user page

  reply	other threads:[~2006-06-06 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-10 21:41 [Qemu-devel] [Patch] Kqemu patch for 2.6.17-rc2 Thomas Petazzoni
2006-06-06 14:15 ` Leonardo E. Reiter [this message]
2006-06-07 20:34   ` Nigel J. Terry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44858E12.2030803@win4lin.com \
    --to=lreiter@win4lin.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.