All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-kernel@vger.kernel.org, iss_storagedev@hp.com,
	Mike Miller <mike.miller@hp.com>
Subject: Re: kinit problem with cciss root device
Date: Tue, 06 Jun 2006 16:44:08 -0700	[thread overview]
Message-ID: <44861348.5030200@zytor.com> (raw)
In-Reply-To: <200606061640.48644.bjorn.helgaas@hp.com>

Bjorn Helgaas wrote:
> kinit converts "root=/dev/cciss/c0d0p1" to "cciss.c0d0", which
> doesn't exist under /sys/block because register_disk() converts
> "cciss/c0d0" to "cciss!c0d0" (note "!", not ".").
> 
> I don't know whether it's the *right* fix, but the patch below
> makes things work.  It still doesn't make kinit exactly match
> the register_disk() behavior because register_disk() only changes
> the first "/" in the string.
> 

That's still the right thing; obviously register_disk() will need to change if we ever 
have deeper trees.

Could you re-send that hunk as a proper patch with Signed-off-by: et al?

Thanks,

	-hpa

      parent reply	other threads:[~2006-06-06 23:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-06 22:40 kinit problem with cciss root device Bjorn Helgaas
2006-06-06 23:25 ` H. Peter Anvin
2006-06-06 23:38   ` H. Peter Anvin
2006-06-06 23:44 ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44861348.5030200@zytor.com \
    --to=hpa@zytor.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=iss_storagedev@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.miller@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.