Re: [Bluez-devel] [PATCH] SCO flow control

[Fabien Chevalier <fabchevalier@free.fr>]

Hi Marcel,

Sorry to be a little late on this answer, however a busy work schedule 
and a sunny Sunday prevented me to answer my e-mails for a few days :-)

> so far I only looked at the changes to the HCI core. Please don't rename
> the disconnect timer. This will collide with the changes for automatic
> sniff mode support.

Ok, however as now sniff mode is out, i would suggest i build on top of 
it :-)

> 
> Can we change the core and add a hci_stream_sco() without breaking the
> API. This would make it easier for me to apply the changes.

I see your point, however i don't see how to bring this feature in 
without breaking the hci core API for SCO sockets... :-(

> 
> Another question is if we really should queue the data in sk_write_queue
> and not directly in the core. I would prefer to send the data to the
> core and then stream it from there.

That's an interesting question... :-)
I asked it myself when i started to design this feature.
In fact having outgoing packets stored in a socket queue has some 
advantages:
   * it makes use of the BSD socket send queue, and thus can reuse some 
generic socket queue management related functions, which rely on some 
well known sk_buff variable (sk_sndbuff, sk_wmem_alloc, sk_rcvbuff, 
sk_rmem_alloc ...)
   * it makes the thing symetrical, both uplink and downlink path make 
use socket queues to buffer data.

As such I thought there were not any valid reason to put in the core... 
however if you have suggestions i would be very happy to hear them. :-)

For now i would suggest we do the following:
   - for you: have a look at the "whole picture", including the SCO part 
patch. This way you would be able to better understand the interaction 
between SCO sockets & hci layer. This way you will be able to send in 
other comments too. :-)
   - for me: * port the patch on top of the 2.6.16-mh1 :-)
             * have it to work also when HZ % 333 != 0 ( i've just seen 
it wouldn't work properly in this case... )

What do you think of the idea ?

Cheers,

Fabien




_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel