All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Anders <anders@anduras.de>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: Negating limit
Date: Thu, 08 Jun 2006 11:12:50 +0200	[thread overview]
Message-ID: <4487EA12.6020609@anduras.de> (raw)
In-Reply-To: <4487D36C.5060708@trash.net>

[-- Attachment #1: Type: text/plain, Size: 1780 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Patrick wrote:

>> Here is a patch to allow a negated "limit", so we can match above and below the
>> limit.
>>
>> It adds a new "flags" variable after the burst. I'm not sure, if I can add it
>> after the "*master" variable, so I added it here.
>> Does this preserve compatibility, because anything after is only used by the kernel?
> 
> No, unfortunately there is no way to add a new variable to that struct
> without breaking compatibility. You could add a new revision, but I
> would like to think about Massimiliano Hofer's patch before that,
> if we do something like that we can get rid of the "master" pointer
> with the new revision.

What do you mean with "new revision"? A new match named "limit2"?

Which of Massimiliano's patches do you mean? The "support for entry data" patch?

To understand correctly:

 Is it not possible under any circumstances to add new variables to a match info
 struct or is the problem the "master" variable?

 If so what is the "master" variable for?

 As far as I understand the size of the "match info struct" passed from the
 userspace must exactly match the size of the kernels "match info struct".
 Right?

Regards
 Sven Anders

- --
 Sven Anders <anders@anduras.de>                 () Ascii Ribbon Campaign
                                                 /\ Support plain text e-mail
 ANDURAS service solutions AG
 Innstraße 71 - 94036 Passau - Germany
 Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEh+oQ5lKZ7Feg4EcRAvHeAJ9JD1tBGvLhZwETVaEpgj/KPZe3KACfcUhG
2/TN39WZ3JjJjwye4xW84i8=
=GIIo
-----END PGP SIGNATURE-----

      reply	other threads:[~2006-06-08  9:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-05 19:54 Negating limit Sven Anders
2006-06-07  9:28 ` Sven Anders
2006-06-08  7:36 ` Patrick McHardy
2006-06-08  9:12   ` Sven Anders [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4487EA12.6020609@anduras.de \
    --to=anders@anduras.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.