Re: [PATCH 02/02] libata: implement ata_eh_wait()

[Jeff Garzik <jgarzik@pobox.com>]

Tejun Heo wrote:
> Jeff Garzik wrote:
>> Tejun Heo wrote:
>>> +    spin_lock_irqsave(&ap->host_set->lock, flags);
>>> +
>>> +    while (ap->flags & (ATA_FLAG_EH_PENDING | 
>>> ATA_FLAG_EH_IN_PROGRESS)) {
>>> +        prepare_to_wait(&ap->eh_wait_q, &wait, TASK_UNINTERRUPTIBLE);
>>> +        spin_unlock_irqrestore(&ap->host_set->lock, flags);
>>> +        schedule();
>>> +        spin_lock_irqsave(&ap->host_set->lock, flags);

DUH.  Ignore my objection, I read the code incorrectly, thinking it was 
just a simple polling delay, when obviously it is not.

ACK.

	Jeff