From: Tejun Heo <htejun@gmail.com>
To: "zhao, forrest" <forrest.zhao@intel.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH v5] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command
Date: Mon, 12 Jun 2006 12:50:53 +0900 [thread overview]
Message-ID: <448CE49D.10004@gmail.com> (raw)
In-Reply-To: <1150081562.5721.26.camel@forrest26.sh.intel.com>
zhao, forrest wrote:
> OK. I ported it to latest #upstream
>
> Signed-off-by: Zhao, Forrest <forrest.zhao@intel.com>
>
The patch looks good to me, but can you repost it with proper header
message? If Jeff applies your patch w/ git-applymbox, "OK. I ported it
to latest #upstream" will end up as the commit message body, which isn't
so descriptive. Please write what the patch does above Signed-off-by.
You can write 'ported to latest #upstream' kind of message below
Signed-off-by separated w/ '---'. For example.
Subject: [PATCH] libata: Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE
command (v5)
[Explain what the patch does.]
Signed-off-by: [....]
---
OK. I ported it to latest #upstream
[If the patch touches a lot of files, including diffstat -p1 result here
would be nice.]
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 11df827..7efe991 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -69,6 +69,8 @@ static void ata_dev_xfermask(struct ata_
....
--
tejun
next prev parent reply other threads:[~2006-06-12 3:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-12 3:06 [PATCH v5] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command zhao, forrest
2006-06-12 3:50 ` Tejun Heo [this message]
2006-06-12 3:53 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448CE49D.10004@gmail.com \
--to=htejun@gmail.com \
--cc=forrest.zhao@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.