Re: [git-patch] hotplug fix patches added

[Tejun Heo <htejun@gmail.com>]

Jeff Garzik wrote:
>> Several drivers only need flags.  IMHO, having to allocate hpriv just 
>> for flags is a bit annoying.  I also thought about separating 
>> capability flags and dynamic flags but couldn't think of proper field 
>> name. ap->dyn_flags?  Also, it would be easy to screw up and test the 
>> wrong field.  Another sucky option was using u64 for flags.
> 
> I tend to think that most drivers fall into two categories:
> 
> * bmdma (PCI IDE-like) drivers
> * drivers which already do their own hpriv allocation and management
> 
> Therefore, I would be OK with adding a bmdma_flags member, to be used 
> only by bmdma drivers [and eventually separated from the high level 
> libata API, as discussed].  Otherwise, I would go ahead and add code to 
> allocate an hpriv structure in the driver.

Okay, bmdma_flags then.  I'll reserve lower 16 bits for generic bmdma 
flags and allow LLDDs to use upper 16 bits.

-- 
tejun