All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Greg KH <gregkh@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
Date: Mon, 12 Jun 2006 19:15:41 -0400	[thread overview]
Message-ID: <448DF59D.3050606@rtr.ca> (raw)
In-Reply-To: <20060612222304.GA21459@suse.de>

Greg KH wrote:
> On Mon, Jun 12, 2006 at 06:12:58PM -0400, Mark Lord wrote:
..
>> Eg. If usb_submit_urb() ever fails again (low on memory, etc..)
>> inside  pl2303_open(), will we be back with the same bug?
>>
>> What's the *real* actual bug here?
> 
> There are two of them.
> 
> The fact that the urb submission in the pl2303 driver fails, and is now
> handled properly is fixed in the pl2303 patch.
> 
> The fact that we can (hopefully) handle scheduling TT in the EHCI driver
> fixes the real problem with plugging slow or full speed devices into a
> USB 2.0 hub (not root hub).  That's fixed by the tt patch.
> 
> So we should have finally covered both of them now.

Yes, agreed.

So if modify pl2303_open() to have it simulate -ENOMEM from usb_submit_urb(),
then this should not crash the entire USB subsystem.  Right?

Ditto if it happens due to low-memory, rather than me hacking the code to test it?

Cheers

  reply	other threads:[~2006-06-12 23:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-12 20:06 pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28 Mark Lord
2006-06-12 20:20 ` Mark Lord
2006-06-12 20:26 ` Lee Revell
2006-06-12 20:41 ` Mark Lord
2006-06-12 20:49 ` Greg KH
2006-06-12 20:56   ` Mark Lord
2006-06-12 21:15   ` Mark Lord
2006-06-12 21:28     ` Greg KH
2006-06-12 21:36       ` Mark Lord
2006-06-12 21:54       ` Mark Lord
2006-06-12 22:03         ` Greg KH
2006-06-12 22:12           ` Mark Lord
2006-06-12 22:23             ` Greg KH
2006-06-12 23:15               ` Mark Lord [this message]
2006-06-12 23:21                 ` Mark Lord
2006-06-13 11:46                   ` Frank Gevaerts
2006-06-13 16:26                     ` Luiz Fernando N. Capitulino
2006-06-13 17:45                       ` Luiz Fernando N. Capitulino
2006-06-14 11:52                         ` [PATCH] clean tty fields on failed device open Frank Gevaerts
2006-06-14 13:49                           ` Luiz Fernando N. Capitulino
2006-06-14 13:52                             ` Frank Gevaerts
2006-06-14 14:13                               ` Luiz Fernando N. Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=448DF59D.3050606@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.