Re: [PATCH] libata: convert several bmdma-style controllers to new EH, take #2

[Tejun Heo <htejun@gmail.com>]

Jeff Garzik wrote:
> Tejun Heo wrote:
>> Convert sata_sis, svw, uli and vsc drivers to new EH.  All the drivers
>> used to specify ATA_FLAG_SATA_RESET to tell libata to use SATA
>> hardreset instead of SRST.
>>
>> This patch preserves the behavior by defining private error handler
>> for each driver which only supports SATA hardreset.  It is likely that
>> all these controllers support SRST and can simply use the stock bmdma
>> EH.  The private EH methods will be removed after each driver is
>> tested w/ the stock bmdma EH.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> Too cautious :)  I don't want to add the duplicate code, and then just 
> remove it later when things are they are supposed to work.
> 
> Just make sure your changes will either (a) work or (b) fail in an 
> obvious way :)
> 
> Then call for testers...

Cool, I like that.  For get this and the via patch.  Will post braver 
version tomorrow.  :)

-- 
tejun