From: Jeff Garzik <jgarzik@pobox.com>
To: "zhao, forrest" <forrest.zhao@intel.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
htejun@gmail.com, linux-ide@vger.kernel.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: Another project for you... :)
Date: Thu, 15 Jun 2006 07:47:26 -0400 [thread overview]
Message-ID: <449148CE.5080604@pobox.com> (raw)
In-Reply-To: <1150358367.7132.100.camel@forrest26.sh.intel.com>
zhao, forrest wrote:
> According to ACPI spec 3.0, _GTM and _STM are IDE-only objects, _SDD is
> SATA-only object. And in your patch you used field "legacy_mode" of
> "struct ata_probe_ent" in order to distinguish between IDE and SATA.
> But after reading the code of ata_pci_init_one(), I found that
> "legacy_mode" is used to distinguish between legacy mode and native PCI
> mode of IDE controller. Am I right? Or did I miss anything?
> If I'm right, I'll fix it during the porting of your patch.
You are correct, you should use cbl==SATA or ATA_FLAG_SATA to check for
SATA. legacy-vs-native is not an accurate check.
Jeff
next prev parent reply other threads:[~2006-06-15 11:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 7:30 [RFC] AHCI Command Completion Coalescing(CCC) proposal zhao, forrest
2006-06-08 15:01 ` Jeff Garzik
2006-06-09 2:27 ` zhao, forrest
2006-06-09 3:11 ` Another project for you... :) Jeff Garzik
2006-06-09 3:13 ` zhao, forrest
2006-06-09 22:29 ` Greg Freemyer
2006-06-09 23:44 ` Alan Cox
2006-06-09 3:43 ` [RFC] ATA host-protected area (HPA) device mapper? Jeff Garzik
2006-06-09 4:51 ` Matthew Frost
2006-06-14 8:01 ` Another project for you... :) zhao, forrest
2006-06-14 15:19 ` Randy.Dunlap
2006-06-15 7:59 ` zhao, forrest
2006-06-15 11:47 ` Jeff Garzik [this message]
2006-06-09 3:30 ` [RFC] AHCI Command Completion Coalescing(CCC) proposal Jeff Garzik
2006-06-09 3:39 ` zhao, forrest
2006-06-09 3:43 ` Tejun Heo
2006-06-09 3:47 ` Tejun Heo
2006-06-09 3:51 ` zhao, forrest
2006-06-09 4:12 ` Jeff Garzik
2006-06-09 5:24 ` Tejun Heo
2006-06-09 11:49 ` Jens Axboe
2006-06-09 3:53 ` Jeff Garzik
2006-06-09 3:52 ` Jeff Garzik
2006-06-09 11:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449148CE.5080604@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=forrest.zhao@intel.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.