All of lore.kernel.org
 help / color / mirror / Atom feed
* Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation
@ 2006-06-15 14:06 Thomas Goirand
  2006-06-15 20:55 ` Morten K. Poulsen
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Thomas Goirand @ 2006-06-15 14:06 UTC (permalink / raw)
  To: mlmmj

Hello,

I have a problem with a setup. It seems mlmmj receives the mail, but it
doesn't sends the confirmation email to postfix. Does one of you know
where and how I should fix it? Any place where I should look at?

What is strange is that it's an automated setup, so it should be the
same setup as I usually use. I really don't understand...

Here is the postfix log:

connect from node0103.gplhost.net[66.251.193.20]

postfix/smtpd[16073]: 46AC5FC015: client=node0103.gplhost.net[66.251.193.20]

postfix/cleanup[16079]: 46AC5FC015: message-id=<449167D7.203@domain1.fr>

postfix/qmgr[19244]: 46AC5FC015: from=<thomas@domain1.fr>, sizeˆ0,
nrcpt=1 (queue active)

postfix/smtpd[16073]: disconnect from node0103.gplhost.net[66.251.193.20]

postfix/smtpd[16083]: connect from localhost[127.0.0.1]

postfix/smtpd[16083]: 31066FC018: client=localhost[127.0.0.1]

postfix/cleanup[16079]: 31066FC018: message-id=<449167D7.203@domain1.fr>

postfix/qmgr[19244]: 31066FC018: from=<thomas@domain1.fr>, size\x1430,
nrcpt=1 (queue active)

postfix/smtpd[16083]: disconnect from localhost[127.0.0.1]

amavis[19261]: (19261-04) Passed, <thomas@domain1.fr> ->
<stoppnazistene.no_testzigo-subscribe@mx.xen330220.gplhost.com>,
Message-ID: <449167D7.203@domain1.fr>, Hits: -

postfix/smtp[16081]: 46AC5FC015:
to=<stoppnazistene.no_testzigo-subscribe@mx.xen330220.gplhost.com>,
orig_to=<testzigo-subscribe@stoppnazistene.no>,
relay\x127.0.0.1[127.0.0.1], delay=2, status=sent (250 2.6.0 Ok,
id\x19261-04, from MTA: 250 Ok: queued as 31066FC018)

postfix/qmgr[19244]: 46AC5FC015: removed

postfix/local[16085]: 31066FC018:
to=<stoppnazistene.no_testzigo-subscribe@mx.xen330220.gplhost.com>,
relay=local, delay=1, status=sent (delivered to command:
/usr/bin/mlmmj-recieve -L
/var/www/sites/dtc/stoppnazistene.no/lists/stoppnazistene.no_testzigo/)

postfix/qmgr[19244]: 31066FC018: removed

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation
  2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
@ 2006-06-15 20:55 ` Morten K. Poulsen
  2006-06-17 19:16 ` Mail sent to mlmmj-recieve but MLMMJ don't send subscribe Christoph Wilke
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Morten K. Poulsen @ 2006-06-15 20:55 UTC (permalink / raw)
  To: mlmmj

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi,

On Thu, 15 Jun 2006 22:06:56 +0800, Thomas Goirand <thomas@goirand.fr> wrote:
> I have a problem with a setup. It seems mlmmj receives the mail, but it
> doesn't sends the confirmation email to postfix.

Have you looked at mlmmj's log messages in your syslog?

I have added a lot of logging since our last release. If you cannot find
anything useful in your syslog, and are able to compile mlmmj yourself, try
applying the attached patch. It should give you more information about why a
given mail is discarded.

Morten

--
Morten K. Poulsen <morten@afdelingp.dk>
http://www.afdelingp.dk/

[-- Attachment #2: patch-mlmmj-listcontrol_logmsgs.diff --]
[-- Type: text/plain, Size: 16183 bytes --]

Index: mlmmj-process.c
===================================================================
RCS file: /home/mmj/MMJCVS/mlmmj/src/mlmmj-process.c,v
retrieving revision 1.74
retrieving revision 1.75
diff -u -r1.74 -r1.75
--- mlmmj-process.c	18 Jan 2006 23:37:58 -0000	1.74
+++ mlmmj-process.c	27 Jan 2006 00:33:03 -0000	1.75
@@ -1,6 +1,6 @@
 /* Copyright (C) 2003, 2003, 2004 Mads Martin Joergensen <mmj at mmj.dk>
  *
- * $Id: mlmmj-process.c,v 1.74 2006/01/18 23:37:58 mortenp Exp $
+ * $Id: mlmmj-process.c,v 1.75 2006/01/27 00:33:03 mortenp Exp $
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to
@@ -578,6 +578,8 @@
 		listcontrol(&fromemails, listdir, whichto->emaillist[0],
 			    mlmmjsub, mlmmjunsub, mlmmjsend, mlmmjbounce,
 			    donemailname);
+		unlink(donemailname);
+
 		return EXIT_SUCCESS;
 	}
 
Index: listcontrol.c
===================================================================
RCS file: /home/mmj/MMJCVS/mlmmj/src/listcontrol.c,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -r1.43 -r1.44
--- listcontrol.c	4 Jan 2006 19:10:24 -0000	1.43
+++ listcontrol.c	27 Jan 2006 00:33:48 -0000	1.44
@@ -1,6 +1,6 @@
 /* Copyright (C) 2003 Mads Martin Joergensen <mmj at mmj.dk>
  *
- * $Id: listcontrol.c,v 1.43 2006/01/04 19:10:24 mmj Exp $
+ * $Id: listcontrol.c,v 1.44 2006/01/27 00:33:48 mortenp Exp $
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to
@@ -113,6 +113,7 @@
 	size_t cmdlen;
 	unsigned int ctrl;
 	struct strlist *owners;
+	int owner_idx;
 	
 	/* A closed list doesn't allow subscribtion and unsubscription */
 	closedlist = statctrl(listdir, "closedlist");
@@ -148,8 +149,16 @@
 		if (strncmp(controlstr, ctrl_commands[ctrl].command, cmdlen)
 				== 0) {
 
-			if (ctrl_commands[ctrl].accepts_parameter &&
-					(controlstr[cmdlen] == '-')) {
+			if (ctrl_commands[ctrl].accepts_parameter) {
+				if (controlstr[cmdlen] != '-') {
+					errno = 0;
+					log_error(LOG_ARGS, "Command \"%s\""
+						" requires a parameter, but no"
+						" parameter was given."
+						" Ignoring mail",
+						ctrl_commands[ctrl].command);
+					return -1;
+                                }
 				param = mystrdup(controlstr + cmdlen + 1);
 				MY_ASSERT(param);
 				if (strchr(param, '/')) {
@@ -157,15 +166,20 @@
 					log_error(LOG_ARGS, "Slash (/) in"
 						" list control request,"
 						" discarding mail");
-					exit(EXIT_SUCCESS);
+					return -1;
 				}
-			} else if (!ctrl_commands[ctrl].accepts_parameter &&
-					(controlstr[cmdlen] == '\0')) {
-				param = NULL;
+
 			} else {
-				/* malformed request, ignore and clean up */
-				unlink(mailname);
-				exit(EXIT_SUCCESS);
+				if (controlstr[cmdlen] != '\0') {
+					errno = 0;
+					log_error(LOG_ARGS, "Command \"%s\""
+						" does not accept a parameter,"
+						" but a parameter was given."
+						" Ignoring mail",
+						ctrl_commands[ctrl].command);
+					return -1;
+				}
+				param = NULL;
 			}
 
 			myfree(controlstr);
@@ -176,22 +190,30 @@
 	
 	/* Only allow mails with bad From: header to be bounce mails */
 	if(fromemails->emailcount != 1 && ctrl != CTRL_BOUNCES) {
-		log_error(LOG_ARGS, "Discarding mail with invalid From: "
+		errno = 0;
+		log_error(LOG_ARGS, "Ignoring mail with invalid From: "
 				"which was not a bounce");
-		unlink(mailname);
-		exit(EXIT_SUCCESS);
+		return -1;
 	}
 
 	switch (ctrl) {
 
 	/* listname+subscribe-digest@domain.tld */
 	case CTRL_SUBSCRIBE_DIGEST:
-		unlink(mailname);
-		if (closedlist || closedlistsub)
-			exit(EXIT_SUCCESS);
-		if (!strchr(fromemails->emaillist[0], '@'))
-			/* Not a valid From: address, silently ignore */
-			exit(EXIT_SUCCESS);
+		if (closedlist || closedlistsub) {
+			errno = 0;
+			log_error(LOG_ARGS, "A subscribe-digest request was"
+				" sent to a closed list. Ignoring mail");
+			return -1;
+		}
+		if (!strchr(fromemails->emaillist[0], '@')) {
+			/* Not a valid From: address */
+			errno = 0;
+			log_error(LOG_ARGS, "A subscribe-digest request was"
+				" sent with an invalid From: header."
+				" Ignoring mail");
+			return -1;
+		}
 		log_oper(listdir, OPLOGFNAME, "mlmmj-sub: request for digest"
 					" subscription from %s",
 					fromemails->emaillist[0]);
@@ -207,12 +229,20 @@
 
 	/* listname+subscribe-nomail@domain.tld */
 	case CTRL_SUBSCRIBE_NOMAIL:
-		unlink(mailname);
-		if (closedlist || closedlistsub)
-			exit(EXIT_SUCCESS);
-		if (!strchr(fromemails->emaillist[0], '@'))
-			/* Not a valid From: address, silently ignore */
-			exit(EXIT_SUCCESS);
+		if (closedlist || closedlistsub) {
+			errno = 0;
+			log_error(LOG_ARGS, "A subscribe-nomail request was"
+				" sent to a closed list. Ignoring mail");
+			return -1;
+		}
+		if (!strchr(fromemails->emaillist[0], '@')) {
+			/* Not a valid From: address */
+			errno = 0;
+			log_error(LOG_ARGS, "A subscribe-nomail request was"
+				" sent with an invalid From: header."
+				" Ignoring mail");
+			return -1;
+		}
 		log_oper(listdir, OPLOGFNAME, "mlmmj-sub: request for nomail"
 					" subscription from %s",
 					fromemails->emaillist[0]);
@@ -228,12 +258,20 @@
 
 	/* listname+subscribe@domain.tld */
 	case CTRL_SUBSCRIBE:
-		unlink(mailname);
-		if (closedlist || closedlistsub)
-			exit(EXIT_SUCCESS);
-		if (!strchr(fromemails->emaillist[0], '@'))
-			/* Not a valid From: address, silently ignore */
-			exit(EXIT_SUCCESS);
+		if (closedlist || closedlistsub) {
+			errno = 0;
+			log_error(LOG_ARGS, "A subscribe request was"
+				" sent to a closed list. Ignoring mail");
+			return -1;
+		}
+		if (!strchr(fromemails->emaillist[0], '@')) {
+			/* Not a valid From: address */
+			errno = 0;
+			log_error(LOG_ARGS, "A subscribe request was"
+				" sent with an invalid From: header."
+				" Ignoring mail");
+			return -1;
+		}
 		log_oper(listdir, OPLOGFNAME, "mlmmj-sub: request for regular"
 					" subscription from %s",
 					fromemails->emaillist[0]);
@@ -248,12 +286,15 @@
 
 	/* listname+subconf-digest-COOKIE@domain.tld */
 	case CTRL_CONFSUB_DIGEST:
-		unlink(mailname);
 		conffilename = concatstr(3, listdir, "/subconf/", param);
 		myfree(param);
 		if((tmpfd = open(conffilename, O_RDONLY)) < 0) {
-			/* invalid COOKIE, silently ignore */
-			exit(EXIT_SUCCESS);
+			/* invalid COOKIE */
+			errno = 0;
+			log_error(LOG_ARGS, "A subconf-digest request was"
+				" sent with a mismatching cookie."
+				" Ignoring mail");
+			return -1;
 		}
 		tmpstr = mygetline(tmpfd);
 		chomp(tmpstr);
@@ -273,12 +314,15 @@
 
 	/* listname+subconf-nomail-COOKIE@domain.tld */
 	case CTRL_CONFSUB_NOMAIL:
-		unlink(mailname);
 		conffilename = concatstr(3, listdir, "/subconf/", param);
 		myfree(param);
 		if((tmpfd = open(conffilename, O_RDONLY)) < 0) {
-			/* invalid COOKIE, silently ignore */
-			exit(EXIT_SUCCESS);
+			/* invalid COOKIE */
+			errno = 0;
+			log_error(LOG_ARGS, "A subconf-nomail request was"
+				" sent with a mismatching cookie."
+				" Ignoring mail");
+			return -1;
 		}
 		tmpstr = mygetline(tmpfd);
 		chomp(tmpstr);
@@ -298,12 +342,15 @@
 
 	/* listname+subconf-COOKIE@domain.tld */
 	case CTRL_CONFSUB:
-		unlink(mailname);
 		conffilename = concatstr(3, listdir, "/subconf/", param);
 		myfree(param);
 		if((tmpfd = open(conffilename, O_RDONLY)) < 0) {
-			/* invalid COOKIE, silently ignore */
-			exit(EXIT_SUCCESS);
+			/* invalid COOKIE */
+			errno = 0;
+			log_error(LOG_ARGS, "A subconf request was"
+				" sent with a mismatching cookie."
+				" Ignoring mail");
+			return -1;
 		}
 		tmpstr = mygetline(tmpfd);
 		chomp(tmpstr);
@@ -323,12 +370,20 @@
 
 	/* listname+unsubscribe-digest@domain.tld */
 	case CTRL_UNSUBSCRIBE_DIGEST:
-		unlink(mailname);
-		if (closedlist)
-			exit(EXIT_SUCCESS);
-		if (!strchr(fromemails->emaillist[0], '@'))
-			/* Not a valid From: address, silently ignore */
-			exit(EXIT_SUCCESS);
+		if (closedlist) {
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubscribe-digest request was"
+				" sent to a closed list. Ignoring mail");
+			return -1;
+		}
+		if (!strchr(fromemails->emaillist[0], '@')) {
+			/* Not a valid From: address */
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubscribe-digest request was"
+				" sent with an invalid From: header."
+				" Ignoring mail");
+			return -1;
+		}
 		log_oper(listdir, OPLOGFNAME, "mlmmj-unsub: %s requests"
 					" unsubscribe from digest",
 					fromemails->emaillist[0]);
@@ -344,12 +399,20 @@
 
 	/* listname+unsubscribe-nomail@domain.tld */
 	case CTRL_UNSUBSCRIBE_NOMAIL:
-		unlink(mailname);
-		if (closedlist)
-			exit(EXIT_SUCCESS);
-		if (!strchr(fromemails->emaillist[0], '@'))
-			/* Not a valid From: address, silently ignore */
-			exit(EXIT_SUCCESS);
+		if (closedlist) {
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubscribe-nomail request was"
+				" sent to a closed list. Ignoring mail");
+			return -1;
+		}
+		if (!strchr(fromemails->emaillist[0], '@')) {
+			/* Not a valid From: address */
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubscribe-nomail request was"
+				" sent with an invalid From: header."
+				" Ignoring mail");
+			return -1;
+		}
 		log_oper(listdir, OPLOGFNAME, "mlmmj-unsub: %s requests"
 					" unsubscribe from nomail",
 					fromemails->emaillist[0]);
@@ -365,12 +428,20 @@
 
 	/* listname+unsubscribe@domain.tld */
 	case CTRL_UNSUBSCRIBE:
-		unlink(mailname);
-		if (closedlist)
-			exit(EXIT_SUCCESS);
-		if (!strchr(fromemails->emaillist[0], '@'))
-			/* Not a valid From: address, silently ignore */
-			exit(EXIT_SUCCESS);
+		if (closedlist) {
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubscribe request was"
+				" sent to a closed list. Ignoring mail");
+			return -1;
+		}
+		if (!strchr(fromemails->emaillist[0], '@')) {
+			/* Not a valid From: address */
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubscribe request was"
+				" sent with an invalid From: header."
+				" Ignoring mail");
+			return -1;
+		}
 		log_oper(listdir, OPLOGFNAME, "mlmmj-unsub: %s requests"
 					" unsubscribe from regular list",
 					fromemails->emaillist[0]);
@@ -385,14 +456,21 @@
 
 	/* listname+unsubconf-digest-COOKIE@domain.tld */
 	case CTRL_CONFUNSUB_DIGEST:
-		unlink(mailname);
-		if (closedlist)
-			exit(EXIT_SUCCESS);
+		if (closedlist) {
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubconf-digest request was"
+				" sent to a closed list. Ignoring mail");
+			return -1;
+		}
 		conffilename = concatstr(3, listdir, "/unsubconf/", param);
 		myfree(param);
 		if((tmpfd = open(conffilename, O_RDONLY)) < 0) {
-			/* invalid COOKIE, silently ignore */
-			exit(EXIT_SUCCESS);
+			/* invalid COOKIE */
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubconf-digest request was"
+				" sent with a mismatching cookie."
+				" Ignoring mail");
+			return -1;
 		}
 		tmpstr = mygetline(tmpfd);
 		close(tmpfd);
@@ -412,14 +490,21 @@
 
 	/* listname+unsubconf-nomail-COOKIE@domain.tld */
 	case CTRL_CONFUNSUB_NOMAIL:
-		unlink(mailname);
-		if (closedlist)
-			exit(EXIT_SUCCESS);
+		if (closedlist) {
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubconf-nomail request was"
+				" sent to a closed list. Ignoring mail");
+			return -1;
+		}
 		conffilename = concatstr(3, listdir, "/unsubconf/", param);
 		myfree(param);
 		if((tmpfd = open(conffilename, O_RDONLY)) < 0) {
-			/* invalid COOKIE, silently ignore */
-			exit(EXIT_SUCCESS);
+			/* invalid COOKIE */
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubconf-nomail request was"
+				" sent with a mismatching cookie."
+				" Ignoring mail");
+			return -1;
 		}
 		tmpstr = mygetline(tmpfd);
 		close(tmpfd);
@@ -439,14 +524,21 @@
 
 	/* listname+unsubconf-COOKIE@domain.tld */
 	case CTRL_CONFUNSUB:
-		unlink(mailname);
-		if (closedlist)
-			exit(EXIT_SUCCESS);
+		if (closedlist) {
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubconf request was"
+				" sent to a closed list. Ignoring mail");
+			return -1;
+		}
 		conffilename = concatstr(3, listdir, "/unsubconf/", param);
 		myfree(param);
 		if((tmpfd = open(conffilename, O_RDONLY)) < 0) {
-			/* invalid COOKIE, silently ignore */
-			exit(EXIT_SUCCESS);
+			/* invalid COOKIE */
+			errno = 0;
+			log_error(LOG_ARGS, "An unsubconf request was"
+				" sent with a mismatching cookie."
+				" Ignoring mail");
+			return -1;
 		}
 		tmpstr = mygetline(tmpfd);
 		close(tmpfd);
@@ -491,14 +583,18 @@
 	/* listname+moderate-COOKIE@domain.tld */
 	case CTRL_MODERATE:
 		/* TODO Add accept/reject parameter to moderate */
-		unlink(mailname);
 		moderatefilename = concatstr(3, listdir, "/moderation/", param);
 		sendfilename = concatstr(2, moderatefilename, ".sending");
 		myfree(param);
 
 		if(stat(moderatefilename, &stbuf) < 0) {
 			myfree(moderatefilename);
-			exit(EXIT_SUCCESS); /* just exit, no mail to moderate */
+			/* no mail to moderate */
+			errno = 0;
+			log_error(LOG_ARGS, "A moderate request was"
+				" sent with a mismatching cookie."
+				" Ignoring mail");
+			return -1;
 		}
 		/* Rename it to avoid mail being sent twice */
 		if(rename(moderatefilename, sendfilename) < 0) {
@@ -519,34 +615,54 @@
 
 	/* listname+help@domain.tld */
 	case CTRL_HELP:
-		unlink(mailname);
-		if(strchr(fromemails->emaillist[0], '@')) {
-			log_oper(listdir, OPLOGFNAME, "%s requested help",
-				fromemails->emaillist[0]);
-			send_help(listdir, fromemails->emaillist[0],
-				  mlmmjsend);
+		if(!strchr(fromemails->emaillist[0], '@')) {
+			/* Not a valid From: address */
+			errno = 0;
+			log_error(LOG_ARGS, "A help request was"
+				" sent with an invalid From: header."
+				" Ignoring mail");
+			return -1;
 		}
+		log_oper(listdir, OPLOGFNAME, "%s requested help",
+				fromemails->emaillist[0]);
+		send_help(listdir, fromemails->emaillist[0], mlmmjsend);
 		break;
 
 	/* listname+get-INDEX@domain.tld */
 	case CTRL_GET:
-		unlink(mailname);
 		noget = statctrl(listdir, "noget");
-		if(noget)
-			exit(EXIT_SUCCESS);
+		if(noget) {
+			errno = 0;
+			log_error(LOG_ARGS, "A get request was sent to a list"
+				" with the noget option set. Ignoring mail");
+			return -1;
+		}
 		subonlyget = statctrl(listdir, "subonlyget");
-		if(subonlyget)
-			if(is_subbed(listdir, fromemails->emaillist[0]) != 0)
-				exit(EXIT_SUCCESS);
+		if(subonlyget) {
+			if(is_subbed(listdir, fromemails->emaillist[0]) != 0) {
+				errno = 0;
+				log_error(LOG_ARGS, "A get request was sent"
+					" from a non-subscribed address to a"
+					" list with the subonlyget option set."
+					" Ignoring mail");
+				return -1;
+			}
+		}
 		/* sanity check--is it all digits? */
 		for(c = param; *c != '\0'; c++) {
-			if(!isdigit((int)*c))
-				exit(EXIT_SUCCESS);
+			if(!isdigit((int)*c)) {
+				errno = 0;
+				log_error(LOG_ARGS, "The get request contained"
+					" non-digits in index. Ignoring mail");
+				return -1;
+			}
 		}
 		archivefilename = concatstr(3, listdir, "/archive/",
 						param);
-		if(stat(archivefilename, &stbuf) < 0)
-			exit(EXIT_SUCCESS);
+		if(stat(archivefilename, &stbuf) < 0) {
+			log_error(LOG_ARGS, "Unable to open archive file");
+			exit(EXIT_FAILURE);
+		}
 		log_oper(listdir, OPLOGFNAME, "%s got archive/%s",
 				fromemails->emaillist[0], archivefilename);
 		execlp(mlmmjsend, mlmmjsend,
@@ -562,7 +678,7 @@
 
 	/* listname+list@domain.tld */
 	case CTRL_LIST:
-		unlink(mailname);
+		owner_idx = -1;
 		owners = ctrlvalues(listdir, "owner");
 		for(i = 0; i < owners->count; i++) {
 			if(strcmp(fromemails->emaillist[0],
@@ -570,13 +686,29 @@
 				log_oper(listdir, OPLOGFNAME,
 						"%s requested sub list",
 				fromemails->emaillist[0]);
-				send_list(listdir, owners->strs[i], mlmmjsend);
+				owner_idx = i;
+				break;
 			}
 		}
+		if (owner_idx == -1) {
+			errno = 0;
+			log_error(LOG_ARGS, "A list request was sent to the"
+				" list from a non-owner address."
+				" Ignoring mail");
+			return -1;
+		} else {
+			send_list(listdir, owners->strs[owner_idx], mlmmjsend);
+		}
 		break;
-	}
 
-	unlink(mailname);
+	/* listname+???@domain.tld */
+	default:
+		errno = 0;
+		log_error(LOG_ARGS, "Unknown command \"%s\". Ignoring mail",
+								controlstr);
+		return -1;
+
+	}
 
 	return 0;
 }

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Mail sent to mlmmj-recieve but MLMMJ don't send subscribe
  2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
  2006-06-15 20:55 ` Morten K. Poulsen
@ 2006-06-17 19:16 ` Christoph Wilke
  2006-06-18  6:42 ` Thomas Goirand
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Christoph Wilke @ 2006-06-17 19:16 UTC (permalink / raw)
  To: mlmmj

Hej!
On Thu, June 15, 2006 16:06, Thomas Goirand wrote:
> Hello,
>
> I have a problem with a setup. It seems mlmmj receives the mail, but
> it
> doesn't sends the confirmation email to postfix. Does one of you know
> where and how I should fix it? Any place where I should look at?
>
> What is strange is that it's an automated setup, so it should be the
> same setup as I usually use. I really don't understand...
>
> Here is the postfix log:
>
> connect from node0103.gplhost.net[66.251.193.20]
>
[...]
>
> postfix/smtpd[16083]: disconnect from localhost[127.0.0.1]
>
> amavis[19261]: (19261-04) Passed, <thomas@domain1.fr> ->
> <stoppnazistene.no_testzigo-subscribe@mx.xen330220.gplhost.com>,
> Message-ID: <449167D7.203@domain1.fr>, Hits: -
>
> postfix/smtp[16081]: 46AC5FC015:
> to=<stoppnazistene.no_testzigo-subscribe@mx.xen330220.gplhost.com>,
> orig_to=<testzigo-subscribe@stoppnazistene.no>,
> relay\x127.0.0.1[127.0.0.1], delay=2, status=sent (250 2.6.0 Ok,
> id\x19261-04, from MTA: 250 Ok: queued as 31066FC018)

Did you change your command delimeter to a '-' (minus sign)?
If not, this might be the problem and the address should read:
testzigo+subscribe@stoppnazistene.no

Ciao
Chris

>
> postfix/qmgr[19244]: 46AC5FC015: removed
>
[...]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Mail sent to mlmmj-recieve but MLMMJ don't send subscribe
  2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
  2006-06-15 20:55 ` Morten K. Poulsen
  2006-06-17 19:16 ` Mail sent to mlmmj-recieve but MLMMJ don't send subscribe Christoph Wilke
@ 2006-06-18  6:42 ` Thomas Goirand
  2006-06-18  9:24 ` Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Mads Martin Joergensen
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Thomas Goirand @ 2006-06-18  6:42 UTC (permalink / raw)
  To: mlmmj

Christoph Wilke wrote:
> 
> Did you change your command delimeter to a '-' (minus sign)?
> If not, this might be the problem and the address should read:
> testzigo+subscribe@stoppnazistene.no
> 
> Ciao
> Chris

Yes, my control panel does that setup as default. This might change in
the future, as I've noticed that using the '-' delimiter prevent from
using "my-address@my-domain.com". Anyway, this is NOT the problem.

I'll try to use the extensive logs from Martin next week, when I have
finished the migration of my ns2 (which is giving me headaches).

Thomas


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation
  2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
                   ` (2 preceding siblings ...)
  2006-06-18  6:42 ` Thomas Goirand
@ 2006-06-18  9:24 ` Mads Martin Joergensen
  2006-06-19 21:38 ` Mail sent to mlmmj-recieve but MLMMJ don't send subscribeconfirmation Morten K. Poulsen
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Mads Martin Joergensen @ 2006-06-18  9:24 UTC (permalink / raw)
  To: mlmmj

* Thomas Goirand <thomas@goirand.fr> [Jun 18. 2006 08:42]:
> > Did you change your command delimeter to a '-' (minus sign)?
> > If not, this might be the problem and the address should read:
> > testzigo+subscribe@stoppnazistene.no
>
> Yes, my control panel does that setup as default. This might change in
> the future, as I've noticed that using the '-' delimiter prevent from
> using "my-address@my-domain.com". Anyway, this is NOT the problem.
> 
> I'll try to use the extensive logs from Martin next week, when I have
> finished the migration of my ns2 (which is giving me headaches).

Then be aware that if there's more than 1 recipient delimiter in the
address, postfix cannot deliver it. I consider it a postfix bug, but
Vietse thinks otherwise.

Just try and deliver to:

testuser-onedelimiter@some.domain

and

testuser-two-delimiters@some.domain

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Mail sent to mlmmj-recieve but MLMMJ don't send subscribeconfirmation
  2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
                   ` (3 preceding siblings ...)
  2006-06-18  9:24 ` Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Mads Martin Joergensen
@ 2006-06-19 21:38 ` Morten K. Poulsen
  2006-06-20 14:57 ` Thomas Goirand
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Morten K. Poulsen @ 2006-06-19 21:38 UTC (permalink / raw)
  To: mlmmj


On Sun, 18 Jun 2006 14:42:04 +0800, Thomas Goirand <thomas@goirand.fr> wrote:
> Christoph Wilke wrote:
>> Did you change your command delimeter to a '-' (minus sign)?
>> If not, this might be the problem and the address should read:
>> testzigo+subscribe@stoppnazistene.no
> 
> Yes, my control panel does that setup as default. This might change in
> the future, as I've noticed that using the '-' delimiter prevent from
> using "my-address@my-domain.com". Anyway, this is NOT the problem.

How do you know that it is not the problem?

Did you remember to set the "delimiter" option in mlmmj?

Morten

-- 
Morten K. Poulsen <morten@afdelingp.dk>
http://www.afdelingp.dk/


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Mail sent to mlmmj-recieve but MLMMJ don't send subscribeconfirmation
  2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
                   ` (4 preceding siblings ...)
  2006-06-19 21:38 ` Mail sent to mlmmj-recieve but MLMMJ don't send subscribeconfirmation Morten K. Poulsen
@ 2006-06-20 14:57 ` Thomas Goirand
  2006-06-21  9:59 ` Thomas Goirand
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Thomas Goirand @ 2006-06-20 14:57 UTC (permalink / raw)
  To: mlmmj

Morten K. Poulsen wrote:
> On Sun, 18 Jun 2006 14:42:04 +0800, Thomas Goirand <thomas@goirand.fr> wrote:
>> Christoph Wilke wrote:
>>> Did you change your command delimeter to a '-' (minus sign)?
>>> If not, this might be the problem and the address should read:
>>> testzigo+subscribe@stoppnazistene.no
>> Yes, my control panel does that setup as default. This might change in
>> the future, as I've noticed that using the '-' delimiter prevent from
>> using "my-address@my-domain.com". Anyway, this is NOT the problem.
> 
> How do you know that it is not the problem?
> 
> Did you remember to set the "delimiter" option in mlmmj?
> 
> Morten

As I said, we have MLMMJ being setup for all our control panel account,
I have arround 50 VPS setup with Postfix + MLMMJ and there was no
problem on them (at least nobody complained).

This VPS server is setup with the latest CVS version of our control
panel, and that might be the reason (maybe something broken in our CVS?).

Anyway, as I get less busy with super-important-urgent things this week,
I'll be able to check. I'm almost sure it's our fault, I just needed to
check, and there is a big chance that this patch doing extensive logging
will help me to find out.

Thomas

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Mail sent to mlmmj-recieve but MLMMJ don't send subscribeconfirmation
  2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
                   ` (5 preceding siblings ...)
  2006-06-20 14:57 ` Thomas Goirand
@ 2006-06-21  9:59 ` Thomas Goirand
  2006-06-21 12:18 ` Søren Boll Overgaard
  2006-06-21 15:06 ` Thomas Goirand
  8 siblings, 0 replies; 10+ messages in thread
From: Thomas Goirand @ 2006-06-21  9:59 UTC (permalink / raw)
  To: mlmmj

Thomas Goirand wrote:
> Morten K. Poulsen wrote:
>> On Sun, 18 Jun 2006 14:42:04 +0800, Thomas Goirand <thomas@goirand.fr> wrote:
>>> Christoph Wilke wrote:
>>>> Did you change your command delimeter to a '-' (minus sign)?
>>>> If not, this might be the problem and the address should read:
>>>> testzigo+subscribe@stoppnazistene.no
>>> Yes, my control panel does that setup as default. This might change in
>>> the future, as I've noticed that using the '-' delimiter prevent from
>>> using "my-address@my-domain.com". Anyway, this is NOT the problem.
>> How do you know that it is not the problem?
>>
>> Did you remember to set the "delimiter" option in mlmmj?
>>
>> Morten
> 
> As I said, we have MLMMJ being setup for all our control panel account,
> I have arround 50 VPS setup with Postfix + MLMMJ and there was no
> problem on them (at least nobody complained).
> 
> This VPS server is setup with the latest CVS version of our control
> panel, and that might be the reason (maybe something broken in our CVS?).
> 
> Anyway, as I get less busy with super-important-urgent things this week,
> I'll be able to check. I'm almost sure it's our fault, I just needed to
> check, and there is a big chance that this patch doing extensive logging
> will help me to find out.
> 
> Thomas

I've just tried using the source package from unstable debian, plus the
patch you gave me, and MLMMJ doesn't produce anything in the syslog. I
really don't know where to look at, any idea???

Thomas



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Mail sent to mlmmj-recieve but MLMMJ don't send subscribeconfirmation
  2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
                   ` (6 preceding siblings ...)
  2006-06-21  9:59 ` Thomas Goirand
@ 2006-06-21 12:18 ` Søren Boll Overgaard
  2006-06-21 15:06 ` Thomas Goirand
  8 siblings, 0 replies; 10+ messages in thread
From: Søren Boll Overgaard @ 2006-06-21 12:18 UTC (permalink / raw)
  To: mlmmj

On Wed, Jun 21, 2006 at 05:59:31PM +0800, Thomas Goirand wrote:
> 
> I've just tried using the source package from unstable debian, plus the
> patch you gave me, and MLMMJ doesn't produce anything in the syslog. I
> really don't know where to look at, any idea???

Please note that the debian package includes a number of patches which may or
may not cause other patches to be rejected. I haven't actually checked if this
is the case here, I just I would provide a heads-up.

Maybe you would be better off with the pristine source package for testing
patches?

-- 
Søren O.

"Oh, bother" said the Borg, "we've assimilated Pooh".

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Mail sent to mlmmj-recieve but MLMMJ don't send subscribeconfirmation
  2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
                   ` (7 preceding siblings ...)
  2006-06-21 12:18 ` Søren Boll Overgaard
@ 2006-06-21 15:06 ` Thomas Goirand
  8 siblings, 0 replies; 10+ messages in thread
From: Thomas Goirand @ 2006-06-21 15:06 UTC (permalink / raw)
  To: mlmmj

Søren Boll Overgaard wrote:
> On Wed, Jun 21, 2006 at 05:59:31PM +0800, Thomas Goirand wrote:
>> I've just tried using the source package from unstable debian, plus the
>> patch you gave me, and MLMMJ doesn't produce anything in the syslog. I
>> really don't know where to look at, any idea???
> 
> Please note that the debian package includes a number of patches which may or
> may not cause other patches to be rejected. I haven't actually checked if this
> is the case here, I just I would provide a heads-up.
> 
> Maybe you would be better off with the pristine source package for testing
> patches?

I just had a look, the patches in Debian are really minor, the only
thing they patch are:

1/ a display message (the one saying that binaries should be called with
full path)
2/ mlmmj-make-ml.sh
3/ mlmmj php app (which I don't use)

None of them seems to hurt, and the patch that gave Morten was applied
with no error (it was not rejected).

Thomas

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2006-06-21 15:06 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-15 14:06 Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Thomas Goirand
2006-06-15 20:55 ` Morten K. Poulsen
2006-06-17 19:16 ` Mail sent to mlmmj-recieve but MLMMJ don't send subscribe Christoph Wilke
2006-06-18  6:42 ` Thomas Goirand
2006-06-18  9:24 ` Mail sent to mlmmj-recieve but MLMMJ don't send subscribe confirmation Mads Martin Joergensen
2006-06-19 21:38 ` Mail sent to mlmmj-recieve but MLMMJ don't send subscribeconfirmation Morten K. Poulsen
2006-06-20 14:57 ` Thomas Goirand
2006-06-21  9:59 ` Thomas Goirand
2006-06-21 12:18 ` Søren Boll Overgaard
2006-06-21 15:06 ` Thomas Goirand

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.