All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Massimo Di Nitto <fabbione@ubuntu.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs2/tool Makefile util.c
Date: Sat, 17 Jun 2006 11:28:23 +0200	[thread overview]
Message-ID: <4493CB37.3030005@ubuntu.com> (raw)
In-Reply-To: <20060615164049.18131.qmail@sourceware.org>


> --- cluster/gfs2/tool/util.c	2006/05/05 18:06:09	1.4
> +++ cluster/gfs2/tool/util.c	2006/06/15 16:40:48	1.5
> @@ -27,13 +27,14 @@
>  #include <libgen.h>
>  #include <dirent.h>
>  #include <string.h>
> -#include <asm/page.h>
>  
>  #define __user
>  #include <linux/gfs2_ondisk.h>
>  
>  #include "gfs2_tool.h"
>  
> +#define PAGE_SIZE (4096)
> +
>  static char sysfs_buf[PAGE_SIZE];
>  
>  char *__get_sysfs(char *fsname, char *filename)

I am afraid this change will make portability a problem. Quite a bunch of
architectures have different PAGE_SIZE. Perhaps it's worth to dig on why it
doesn't build on x86_64 instead?

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.



      reply	other threads:[~2006-06-17  9:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-15 16:40 [Cluster-devel] cluster/gfs2/tool Makefile util.c adas
2006-06-17  9:28 ` Fabio Massimo Di Nitto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4493CB37.3030005@ubuntu.com \
    --to=fabbione@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.