From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:60678 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727254AbeIEUmx (ORCPT ); Wed, 5 Sep 2018 16:42:53 -0400 From: Laurent Pinchart To: Jacopo Mondi Cc: geert@linux-m68k.org, horms@verge.net.au, kieran.bingham+renesas@ideasonboard.com, niklas.soderlund+renesas@ragnatech.se, damm+renesas@opensource.se, ulrich.hecht+renesas@gmail.com, linux-renesas-soc@vger.kernel.org, Takeshi Kihara Subject: Re: [PATCH v2 7/8] arm64: dts: r8a77990: Add I2C device nodes Date: Wed, 05 Sep 2018 19:12:04 +0300 Message-ID: <4495141.iO50eGj69H@avalon> In-Reply-To: <1536161385-25562-8-git-send-email-jacopo+renesas@jmondi.org> References: <1536161385-25562-1-git-send-email-jacopo+renesas@jmondi.org> <1536161385-25562-8-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Jacopo, Thank you for the patch. On Wednesday, 5 September 2018 18:29:44 EEST Jacopo Mondi wrote: > From: Takeshi Kihara > > Add device nodes for I2C ch[0-7] to R-Car E3 R8A77990 device tree. > > Signed-off-by: Takeshi Kihara > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Tested-by: Laurent Pinchart Simon, could you take this in your tree for v4.20 without waiting for the whole series to be ready ? > --- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 123 +++++++++++++++++++++++++++ > 1 file changed, 123 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index 0ae7bbe..a1badfe 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > @@ -14,6 +14,17 @@ > #address-cells = <2>; > #size-cells = <2>; > > + aliases { > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + i2c2 = &i2c2; > + i2c3 = &i2c3; > + i2c4 = &i2c4; > + i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + }; > + > cpus { > #address-cells = <1>; > #size-cells = <0>; > @@ -185,6 +196,118 @@ > resets = <&cpg 906>; > }; > > + i2c0: i2c@e6500000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a77990", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe6500000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 931>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 931>; > + i2c-scl-internal-delay-ns = <110>; > + status = "disabled"; > + }; > + > + i2c1: i2c@e6508000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a77990", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe6508000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 930>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 930>; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c2: i2c@e6510000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a77990", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe6510000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 929>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 929>; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c3: i2c@e66d0000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a77990", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe66d0000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 928>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 928>; > + i2c-scl-internal-delay-ns = <110>; > + status = "disabled"; > + }; > + > + i2c4: i2c@e66d8000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a77990", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe66d8000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 927>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 927>; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c5: i2c@e66e0000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a77990", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe66e0000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 919>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 919>; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c6: i2c@e66e8000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a77990", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe66e8000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 918>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 918>; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c7: i2c@e6690000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a77990", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe6690000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 1003>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 1003>; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > pfc: pin-controller@e6060000 { > compatible = "renesas,pfc-r8a77990"; > reg = <0 0xe6060000 0 0x508>; -- Regards, Laurent Pinchart