All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jorge Matias Martin <jorge.matias@motorola.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] xt_sctp - add SCTP header size to IP header offset
Date: Mon, 19 Jun 2006 16:53:30 +0200	[thread overview]
Message-ID: <4496BA6A.3040308@trash.net> (raw)
In-Reply-To: <200606081754.09073.jorge.matias@motorola.com>

Jorge Matias Martin wrote:
> Hi, all.
> 
> xt_sctp module is not working on 2.6.16 when --chunk-types option is used. I 
> have test this running sctp_darn and the following iptables options:
> 
> -A INPUT -p sctp --chunk-types any INIT -j DROP
> 
> And this is the kernel log output:
> 
> spt: 32822    dpt: 10105
> Chunk num: 1  offset: 20      type: 128       length: 10105   flags: 36
> skb->len: 92  offset: 10128
> spt: 10105    dpt: 32822
> Chunk num: 1  offset: 20      type: 39        length: 32822   flags: 79
> skb->len: 284 offset: 32844
> spt: 32822    dpt: 10105
> Chunk num: 1  offset: 20      type: 128       length: 10105   flags: 36
> ...
> 
> 
> Note that length is actually the local port, and offset must be 32 (20 IPv4 
> header + 12 SCTP header).
> 
> FYI, it works properly when --chunk-types is not used.

Looks good too me. Please add a Signed-off-by: line so I can
apply it. Thanks.

  reply	other threads:[~2006-06-19 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-08 15:54 [PATCH] xt_sctp - add SCTP header size to IP header offset Jorge Matias Martin
2006-06-19 14:53 ` Patrick McHardy [this message]
2006-06-19 15:58   ` Jorge Matias Martin
2006-06-19 16:07     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4496BA6A.3040308@trash.net \
    --to=kaber@trash.net \
    --cc=jorge.matias@motorola.com \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.