From: Paul Clements <paul.clements@steeleye.com>
To: Paul Clements <paul.clements@steeleye.com>
Cc: Neil Brown <neilb@suse.de>, linux-raid@vger.kernel.org
Subject: Re: [PATCH] ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux
Date: Mon, 19 Jun 2006 15:02:09 -0400 [thread overview]
Message-ID: <4496F4B1.9090604@steeleye.com> (raw)
In-Reply-To: <4496BE1A.8010502@steeleye.com>
Paul Clements wrote:
> --- super1.c 2006-06-19 05:17:36.000000000 -0400
> +++ /export/public/clemep/tmp/super1-ppc-compile-error.c 2006-06-19 00:40:26.000000000 -0400
> @@ -124,8 +124,11 @@ static unsigned int calc_sb_1_csum(struc
> disk_csum = sb->sb_csum;
> sb->sb_csum = 0;
> newcsum = 0;
> - for (i=0; size>=4; size -= 4 )
> - newcsum += __le32_to_cpu(*isuper++);
> + for (i=0; size>=4; size -= 4 ) {
> + unsigned int *x = isuper;
> + newcsum += __le32_to_cpu(*x);
> + x++;
> + }
Should be more like:
for (i=0; size>=4; size -= 4 ) {
newcsum += __le32_to_cpu(*isuper);
isuper++;
}
Duh... :)
next prev parent reply other threads:[~2006-06-19 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-16 1:03 ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux Neil Brown
2006-06-16 15:46 ` Paul Clements
2006-06-16 17:54 ` Bill Davidsen
2006-06-19 15:09 ` [PATCH] " Paul Clements
2006-06-19 18:58 ` Paul Clements
2006-06-20 0:04 ` Neil Brown
2006-06-19 19:02 ` Paul Clements [this message]
2006-06-17 2:12 ` mdadm 2.5.1 - A problem came up Mr. James W. Laferriere
2006-06-17 7:00 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4496F4B1.9090604@steeleye.com \
--to=paul.clements@steeleye.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.