Re: [Qemu-devel] [PATCH] mips-user socket-related syscall support

[Fabrice Bellard <fabrice@bellard.org>]

Another point is that doing:

+    target_long args[6];
+
+    tputl(args, arg1);
+    tputl(args+1, arg2);
+    tputl(args+2, arg3);
+    tputl(args+3, arg4);
+    tputl(args+4, arg5);
+    tputl(args+5, arg6);

at the start of every syscall is not acceptable. You should add a 
specific socket call wrapper which takes arg1... arg6 as arguments.

Regards,

Fabrice.

Raphaël Rigo wrote:
> Hello,
> this patch is a revamped version of the one I posted about 2 months ago,
> it is much better. It implements the syscalls related to sockets on the
> MIPS platform (because it has no "socketcall" syscall). I had to create
> a "socket.h" file defining the constants for the targets because MIPS
> doesn't have the same as every other platform.
> 
> The calls implemented are : accept, bind, connect, getpeername,
> getsockname, listen, recv, recvfrom, recvmsg, send, sendmsg, sendto,
> shutdown, socket, socketpair.
> 
> Combined with the other patch I just posted (signal handling), qemu-mips
> is now capable of running a webserver (which is very nice :)
> 
> Please consider it for inclusion into mainline.
> 
> Raphaël Rigo