Re: [PATCH] entry_data

[Pablo Neira Ayuso <pablo@netfilter.org>]

Massimiliano Hofer wrote:
> 
>>                         /* Used inside the kernel */
>>                         struct xt_match *match;
>>+                       void *entry_data;
>>                 } kernel;
>>
>>You can't modify the layout of xt_entry_[match|target] since this
>>structure is shared between userspace (iptables) and kernel space.
> 
> 
> You're right, but I modified the kernel side of a union and I was careful not 
> to change the total size. This union is never really used by both sides 
> simultaneously.

Indeed, you're right, I can't see any problem with your patch at this 
moment. Although apart from the out of tree xt_condition match, there is 
no other clients for entry_data. I'd like to know what Patrick thinks 
about this.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of 
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris