From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Bongani Hlope <bhlope@mweb.co.za>,
linux-kernel@vger.kernel.org, len.brown@intel.com
Subject: Re: [UBUNTU:acpi/ec] Use semaphore instead of spinlock
Date: Mon, 19 Jun 2006 17:41:20 -0700 [thread overview]
Message-ID: <44974430.8050807@oracle.com> (raw)
In-Reply-To: <20060619174006.647e02c7.akpm@osdl.org>
Andrew Morton wrote:
> Bongani Hlope <bhlope@mweb.co.za> wrote:
>>> @@ -342,7 +341,10 @@ static int acpi_ec_poll_read(union acpi_
>>> return_VALUE(-ENODEV);
>>> }
>>>
>>> - spin_lock_irqsave(&ec->poll.lock, flags);
>>> + if (down_interruptible(&ec->polling.sem)) {
>> ^^^^
>> isn't this suppose to be: &ec->poll.sem
>
> Good question. Did it get resolved?
I posted a corrected patch that does that.
No responses from the ACPI people.
~Randy
next prev parent reply other threads:[~2006-06-20 0:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-14 23:22 [UBUNTU:acpi/ec] Use semaphore instead of spinlock Randy Dunlap
2006-06-15 5:38 ` Bongani Hlope
2006-06-20 0:40 ` Andrew Morton
2006-06-20 0:41 ` Randy Dunlap [this message]
2006-06-20 1:10 ` Andrew Morton
2006-06-16 14:31 ` Luiz Fernando N. Capitulino
2006-06-16 17:43 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2006-06-14 23:08 Voluspa
2006-06-15 0:26 ` Randy Dunlap
2006-06-15 1:14 ` Randy Dunlap
2006-06-15 5:45 ` Roland Dreier
2006-06-15 11:03 ` Voluspa
2006-06-15 16:27 ` Lee Revell
2006-06-16 9:23 ` Voluspa
2006-06-17 2:57 ` Lee Revell
2006-06-15 15:40 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44974430.8050807@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=bhlope@mweb.co.za \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.