All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Eric Leblond <eric@inl.fr>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH 1/2] Specify nf_queue max length from userspace
Date: Tue, 20 Jun 2006 03:21:29 +0200	[thread overview]
Message-ID: <44974D99.8000807@trash.net> (raw)
In-Reply-To: <1150747030.6979.6.camel@porky>

Eric Leblond wrote:
> I did not like the idea of having params split between two structures.
> And as the user base is still small, I thought we may break ABI to have
> something cleaner.
> Pablo and you do not like the idea, I wrote a patch that should not
> break the ABI (attached to the mail).
> In fact, after introducing the new attribute, I just found it is in a
> way cleaner than my initial one because code does not depend from a
> structure.

Yes, that is better. I still would prefer to have all configuration
attributes nested under some common attribute .. but I can't see a
clean way to do that right now. Let me think about this some more.

  reply	other threads:[~2006-06-20  1:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-13 16:56 [PATCH 0/2] Specify nf_queue max length from userspace Eric Leblond
2006-06-13 17:06 ` [PATCH 1/2] " Eric Leblond
2006-06-16 12:36   ` Pablo Neira Ayuso
2006-06-17 21:24     ` Eric Leblond
2006-06-18 17:13       ` Pablo Neira Ayuso
2006-06-19 16:26   ` Patrick McHardy
2006-06-19 19:57     ` Eric Leblond
2006-06-20  1:21       ` Patrick McHardy [this message]
2006-06-19 20:01     ` [PATCH 2/2] " Eric Leblond
2006-06-13 17:07 ` [PATCH 2/2] [libnetfilter_queue] " Eric Leblond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44974D99.8000807@trash.net \
    --to=kaber@trash.net \
    --cc=eric@inl.fr \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.