All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Mahoney <jeffm@suse.com>
To: Andrew Morton <akpm@osdl.org>
Cc: ReiserFS List <reiserfs-list@namesys.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>
Subject: [PATCH] reiserfs: use generic_file_open for open() checks
Date: Tue, 20 Jun 2006 14:25:13 -0400	[thread overview]
Message-ID: <44983D89.7040400@suse.com> (raw)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 The other common disk-based file systems (I checked ext[23], xfs, jfs)
 check to ensure that opens of files > 2 GB fail unless O_LARGEFILE
 is specified. They check via generic_file_open or their own open routine.

 ReiserFS doesn't have an f_op->open defined, and as such, it's possible to
 open files > 2 GB without O_LARGEFILE.

 This patch adds the f_op->open member to conform with the expected
 behavior.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
- --

 fs/reiserfs/file.c |    1 +
 1 file changed, 1 insertion(+)

diff -ruNpX dontdiff linux-2.6.17-rc5.orig/fs/reiserfs/file.c linux-2.6.17-rc5.reiser/fs/reiserfs/file.c
- --- linux-2.6.17-rc5.orig/fs/reiserfs/file.c	2006-06-05 10:37:26.000000000 -0400
+++ linux-2.6.17-rc5.reiser/fs/reiserfs/file.c	2006-06-07 10:09:24.000000000 -0400
@@ -1571,6 +1571,7 @@ const struct file_operations reiserfs_fi
 	.write = reiserfs_file_write,
 	.ioctl = reiserfs_ioctl,
 	.mmap = generic_file_mmap,
+	.open = generic_file_open,
 	.release = reiserfs_file_release,
 	.fsync = reiserfs_sync_file,
 	.sendfile = generic_file_sendfile,

- -- 
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEmD2JLPWxlyuTD7IRAgAEAJ4mdjOTfjYnxkerzBvERvOaDubQOQCfcQRK
IWtRqpF+mkhZfbjtnkGxvPA=
=/8oU
-----END PGP SIGNATURE-----

                 reply	other threads:[~2006-06-20 18:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44983D89.7040400@suse.com \
    --to=jeffm@suse.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reiserfs-list@namesys.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.