All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Kyle McMartin <kyle@parisc-linux.org>,
	jeremy@goop.org, linux-kernel@vger.kernel.org,
	Christian.Limpach@cl.cam.ac.uk, chrisw@sous-sol.org
Subject: Re: [PATCH] Implement kasprintf
Date: Tue, 20 Jun 2006 21:30:39 -0700	[thread overview]
Message-ID: <4498CB6F.9000003@zytor.com> (raw)
In-Reply-To: <20060620202617.f39d7ca6.akpm@osdl.org>

Andrew Morton wrote:
> On Tue, 20 Jun 2006 23:04:44 -0400
> Kyle McMartin <kyle@parisc-linux.org> wrote:
> 
>> On Tue, Jun 20, 2006 at 04:57:16PM -0700, Jeremy Fitzhardinge wrote:
>>> +char *kasprintf(gfp_t gfp, const char *fmt, ...)
>>> +{
>> Why not just asprintf? We don't have ksprintf... 
> asprintf() doesn't take a gfp_t arg.
> 

Or, more generally: if we change the API, change the name.  kmalloc() is 
different from malloc() as it is invoked differently, as is kasprintf().

printk() was arguably a mistake, although it's semi-justified a posteori 
since it takes the priority pseudo-argument now.

	-hpa

  reply	other threads:[~2006-06-21  4:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-20 23:57 [PATCH] Implement kasprintf Jeremy Fitzhardinge
2006-06-21  0:10 ` Randy.Dunlap
2006-06-21  0:14   ` Jeremy Fitzhardinge
2006-06-21  0:26     ` Randy.Dunlap
2006-06-21  0:31       ` Jeremy Fitzhardinge
2006-06-21  3:04 ` Kyle McMartin
2006-06-21  3:26   ` Andrew Morton
2006-06-21  4:30     ` H. Peter Anvin [this message]
2006-06-21 11:58     ` Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4498CB6F.9000003@zytor.com \
    --to=hpa@zytor.com \
    --cc=Christian.Limpach@cl.cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=chrisw@sous-sol.org \
    --cc=jeremy@goop.org \
    --cc=kyle@parisc-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.