From: Peter Williams <pwil3058@bigpond.net.au>
To: Matt Helsley <matthltc@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Jes Sorensen <jes@sgi.com>,
LSE-Tech <lse-tech@lists.sourceforge.net>,
Chandra S Seetharaman <sekharan@us.ibm.com>,
Alan Stern <stern@rowland.harvard.edu>,
John T Kohl <jtk@us.ibm.com>, Balbir Singh <balbir@in.ibm.com>,
Shailabh Nagar <nagar@watson.ibm.com>
Subject: Re: [PATCH 00/11] Task watchers: Introduction
Date: Wed, 21 Jun 2006 21:41:45 +1000 [thread overview]
Message-ID: <44993079.40300@bigpond.net.au> (raw)
In-Reply-To: <44992EAA.6060805@bigpond.net.au>
Peter Williams wrote:
> Matt Helsley wrote:
>> On Wed, 2006-06-21 at 15:41 +1000, Peter Williams wrote:
>>> On a related note, I can't see where the new task's notify field gets
>>> initialized during fork.
>>
>> It's initialized in kernel/sys.c:notify_per_task_watchers(), which calls
>> RAW_INIT_NOTIFIER_HEAD(&task->notify) in response to WATCH_TASK_INIT.
>
> I think that's too late. It needs to be done at the start of
> notify_watchers() before any other watchers are called for the new task.
On second thoughts, it would simpler just before the WATCH_TASK_INIT
call in copy_process() in fork.c. It can be done unconditionally there.
Peter
--
Peter Williams pwil3058@bigpond.net.au
"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce
next prev parent reply other threads:[~2006-06-21 11:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-13 23:52 [PATCH 00/11] Task watchers: Introduction Matt Helsley
2006-06-19 10:24 ` Andrew Morton
2006-06-21 8:35 ` Matt Helsley
2006-06-21 9:07 ` Andrew Morton
2006-06-21 9:13 ` [Lse-tech] " Matt Helsley
2006-06-21 10:40 ` Peter Williams
2006-06-21 21:32 ` Matt Helsley
2006-06-21 5:41 ` Peter Williams
2006-06-21 7:51 ` Matt Helsley
2006-06-21 11:34 ` Peter Williams
2006-06-21 11:41 ` Peter Williams [this message]
2006-06-21 21:29 ` Matt Helsley
2006-06-21 23:04 ` Peter Williams
2006-06-22 0:32 ` Matt Helsley
2006-06-22 1:11 ` Peter Williams
2006-06-22 3:46 ` Matt Helsley
2006-06-22 4:26 ` Peter Williams
2006-06-22 5:37 ` [Lse-tech] " Matt Helsley
2006-06-22 6:29 ` Peter Williams
2006-06-22 19:53 ` Chandra Seetharaman
2006-06-22 22:46 ` Peter Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44993079.40300@bigpond.net.au \
--to=pwil3058@bigpond.net.au \
--cc=akpm@osdl.org \
--cc=balbir@in.ibm.com \
--cc=jes@sgi.com \
--cc=jtk@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=matthltc@us.ibm.com \
--cc=nagar@watson.ibm.com \
--cc=sekharan@us.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.