All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: adam radford <aradford@gmail.com>
Cc: scsi <linux-scsi@vger.kernel.org>, akpm <akpm@osdl.org>,
	jejb <James.Bottomley@steeleye.com>,
	linuxraid@amcc.com
Subject: Re: [Ubuntu PATCH] 3w-9xyz: add proc_name
Date: Wed, 21 Jun 2006 13:50:08 -0700	[thread overview]
Message-ID: <4499B100.6010309@oracle.com> (raw)
In-Reply-To: <b1bc6a000606211123h598ff564i5b8a25bb92e19a00@mail.gmail.com>

adam radford wrote:
> Randy,
> 
> Is there any reason why any of these proc_name patches need to
> go in after James Smart's explanation:

Nope.  Thanks for your comments.

~Randy

> http://marc.theaimsgroup.com/?l=linux-scsi&m=115040210406375&w=2
> 
> in particular, the part about:
> 
> "- scsi_proc_hostdir_add() validates that sht->proc_info is non-null before
>   attempting to use sht->proc_name."
> 
> proc_info is null for the 3w-9xxx driver.
> 
> -Adam
> 
> On 6/20/06, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> Add .proc_name member to scsi_host_template for 3w-9xxx.
>>
>> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=12fdf64086335ed596848cf17602e7a71e15ae9b
>>
>>
>>
>> ---
>>  drivers/scsi/3w-9xxx.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-2617-pv.orig/drivers/scsi/3w-9xxx.c
>> +++ linux-2617-pv/drivers/scsi/3w-9xxx.c
>> @@ -2011,6 +2011,7 @@ static void twa_unmap_scsi_data(TW_Devic
>>  /* scsi_host_template initializer */
>>  static struct scsi_host_template driver_template = {
>>         .module                 = THIS_MODULE,
>> +       .proc_name              = "3w-9xxx",
>>         .name                   = "3ware 9000 Storage Controller",
>>         .queuecommand           = twa_scsi_queue,
>>         .eh_host_reset_handler  = twa_scsi_eh_reset,
>>
>>
>>
>> -


      reply	other threads:[~2006-06-21 20:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21  5:32 [Ubuntu PATCH] 3w-9xyz: add proc_name Randy Dunlap
2006-06-21 18:23 ` adam radford
2006-06-21 20:50   ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4499B100.6010309@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=aradford@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxraid@amcc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.