Re: [PATCH 1/1] New Framebuffer for Intel based Macs [try #3]

["Antonino A. Daplas" <adaplas@gmail.com>]

Edgar Hucek wrote:
> This patch add a new framebuffer driver for the Intel Based macs.
> This framebuffer is needed when booting from EFI to get something
> out the box   ;) 
> [try #2] Removed unused and untested code in this version of the patch.
> [try #3] Just cleanup to meet the coding guideline.
> 
> Signed-off-by: Edgar Hucek <hostmaster@ed-soft.at>
Acked-by: Antonino Daplas <adaplas@pol.net>

I'll pick this up if Andrew or Linus doesn't.

Tony

> +#define	DEFAULT_FB_MEM	1024*1024*16

nitpick: parenthesis around the value?


> +
> +static struct platform_device imacfb_device = {
> +	.name	= "imacfb",
> +};

You might update this sometime in the future to use
platform_device_alloc().