Re: [PATCH 3/6] Blacklist PCI-E chipsets depending on Hypertransport MSI capabality

[Brice Goglin <brice@myri.com>]

Dave Olson wrote:
> On Wed, 21 Jun 2006, Brice Goglin wrote:
>
> | [PATCH 3/6] Blacklist PCI-E chipsets depending on Hypertransport MSI capabality
> | 
> | Introduce msi_ht_cap_enabled() to check the MSI capability in the
> | Hypertransport configuration space.
> | It is used in a generic quirk quirk_msi_ht_cap() to check whether
> | MSI is enabled on hypertransport chipset, and a nVidia specific quirk
> | quirk_nvidia_ck804_msi_ht_cap() where two 2 HT MSI mappings have to
> | be checked.
> | Both quirks set the PCI_BUS_FLAGS_NO_MSI flags when MSI is disabled.
> ...
> | Index: linux-mm/drivers/pci/quirks.c
>
> | +/* Returns 1 if the HT MSI capability is found and enabled */
> | +static pci_bus_flags_t __devinit msi_ht_cap_enabled(struct pci_dev *dev)
> | +{
> | +
> | +	/* go through all caps looking for a hypertransport msi mapping */
> | +	while (pci_read_config_byte(dev, cap_off + 1, &cap_off) == 0 &&
>
> Perhaps this could be modified to use pci_find_capability() and pci_find_next_capability(),
> rather than writing your own code to do it?
>   

Right, pci_find_next_capability() should help here. I am rewriting the
patch.
thanks,
Brice