From: Michael Krufky <mkrufky@linuxtv.org>
To: predivan@ptt.yu
Cc: v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [PATCH][2.6.17]drivers/media/video/bt8xx/bttvp.h has wrong include line
Date: Thu, 22 Jun 2006 10:26:45 -0400 [thread overview]
Message-ID: <449AA8A5.8070903@linuxtv.org> (raw)
In-Reply-To: <20060622145850.0cf87d8a.predivan@ptt.yu>
Predrag Ivanovic wrote:
> Hi.
> Trivial patch, really.
> Fixes include line in bttvp.h(btcx-risc.h is in parent dir).
> ------
> --- bttvp.h 2006-06-19 16:48:46.000000000 +0200
> +++ bttvp.h.new 2006-06-19 16:49:54.000000000 +0200
> @@ -48,7 +48,7 @@
>
> #include "bt848.h"
> #include "bttv.h"
> -#include "btcx-risc.h"
> +#include "../btcx-risc.h"
>
> #ifdef __KERNEL__
>
> -----------
> Pedja
>
NACK.
Please see drivers/media/video/bt8xx/Makefile
You will notice the following line:
EXTRA_CFLAGS += -Idrivers/media/video
This instructs the compiler to find some other required headers in
drivers/media/video (such as btcx-risc.h)
Your patch is unnecessary, and it is bad practice to use ".." inside a
header includes path, IMHO at least.
In addition, please see the guidelines in
Documentation/SubmittingPatches before you send any future patches. We
cannot accept patches into the linux kernel without a proper developer's
certificate of origin.
Thank you for the effort, though :-)
Regards,
Michael Krufky
prev parent reply other threads:[~2006-06-22 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 12:58 [PATCH][2.6.17]drivers/media/video/bt8xx/bttvp.h has wrong include line Predrag Ivanovic
2006-06-22 14:26 ` Michael Krufky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449AA8A5.8070903@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=predivan@ptt.yu \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.