From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FtSlH-0005QQ-AV
	for qemu-devel@nongnu.org; Thu, 22 Jun 2006 13:14:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FtSlF-0005QD-M4
	for qemu-devel@nongnu.org; Thu, 22 Jun 2006 13:14:35 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FtSlF-0005QA-Fp
	for qemu-devel@nongnu.org; Thu, 22 Jun 2006 13:14:33 -0400
Received: from [82.227.67.108] (helo=valhalla.twilight-hall.net)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1FtSwG-00083v-EJ
	for qemu-devel@nongnu.org; Thu, 22 Jun 2006 13:25:56 -0400
Message-ID: <449ACFF6.3050704@twilight-hall.net>
Date: Thu, 22 Jun 2006 19:14:30 +0200
From: =?ISO-8859-1?Q?Rapha=EBl_Rigo?= <ml-qemu@twilight-hall.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] mips-user socket-related syscall support
References: <449667B1.5070300@twilight-hall.net> <44972A98.6060905@bellard.org>
	<4497B611.30809@twilight-hall.net>
In-Reply-To: <4497B611.30809@twilight-hall.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Rapha=EBl Rigo wrote:
> Fabrice Bellard wrote:
>> Another point is that doing:
>>
>> +    target_long args[6];
>> +
>> +    tputl(args, arg1);
>> +    tputl(args+1, arg2);
>> +    tputl(args+2, arg3);
>> +    tputl(args+3, arg4);
>> +    tputl(args+4, arg5);
>> +    tputl(args+5, arg6);
>>
>> at the start of every syscall is not acceptable. You should add a
>> specific socket call wrapper which takes arg1... arg6 as arguments.
>>
>> Regards,
>>
>> Fabrice.
> Thanks for reviewing it, the new attached version should be much cleane=
r.
>=20
> Regards,
> Rapha=EBl
Sorry to insist, but can you please include it in the CVS? I really think=
 it's
useful.

Thanks,
Rapha=EBl