From: Jim Cromie <jim.cromie@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Subject: [ patch -mm1 04/11 ] gpio-patchset-fixups: request-region
Date: Thu, 22 Jun 2006 12:51:08 -0600 [thread overview]
Message-ID: <449AE69C.1040404@gmail.com> (raw)
diff.13-fix-request-region
Usage of request_region() was wrong ( returns 0 on error - docpatch sent
to trivial ).
This fixes it, and clarifies the err-msg.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
diff -ruNp -X dontdiff -X exclude-diffs 17-mm-pre0/drivers/char/pc8736x_gpio.c 13/drivers/char/pc8736x_gpio.c
--- 17-mm-pre0/drivers/char/pc8736x_gpio.c 2006-06-20 20:42:39.000000000 -0600
+++ 13/drivers/char/pc8736x_gpio.c 2006-06-21 10:31:31.000000000 -0600
@@ -297,9 +297,12 @@ static int __init pc8736x_gpio_init(void
pc8736x_gpio_base = (superio_inb(SIO_BASE_HADDR) << 8
| superio_inb(SIO_BASE_LADDR));
- if (request_region(pc8736x_gpio_base, 16, DEVNAME))
- dev_info(&pdev->dev, "GPIO ioport %x reserved\n",
- pc8736x_gpio_base);
+ if (!request_region(pc8736x_gpio_base, 16, DEVNAME)) {
+ dev_err(&pdev->dev, "GPIO ioport %x busy\n",
+ pc8736x_gpio_base);
+ return -ENODEV;
+ }
+ dev_info(&pdev->dev, "GPIO ioport %x reserved\n", pc8736x_gpio_base);
r = register_chrdev(major, DEVNAME, &pc8736x_gpio_fops);
if (r < 0) {
reply other threads:[~2006-06-22 18:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449AE69C.1040404@gmail.com \
--to=jim.cromie@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.