From: Jim Cromie <jim.cromie@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Subject: [ patch -mm1 05/11 ] gpio-patchset-fixups: include linux/io.h
Date: Thu, 22 Jun 2006 12:51:46 -0600 [thread overview]
Message-ID: <449AE6C2.3090905@gmail.com> (raw)
Hmm. Im somewhat ambivalent about this patch,
since with it, driver wont build for vanilla 17 or older.
Its also only 1/2 of your suggestion - when I tried it, I was building
against vanilla 17,
and asm/uaccess.h cause compilation failure.
Looking back, Im perplexed as to why linux/io.h didnt cause same failure ?!?
----
diff.13-fix-include-linux-io
use linux/io.h rather than asm/io.h
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
diff -ruNp -X dontdiff -X exclude-diffs 17-mm-pre0/drivers/char/pc8736x_gpio.c 13/drivers/char/pc8736x_gpio.c
--- 17-mm-pre0/drivers/char/pc8736x_gpio.c 2006-06-20 20:42:39.000000000 -0600
+++ 13/drivers/char/pc8736x_gpio.c 2006-06-21 10:31:31.000000000 -0600
@@ -15,12 +15,12 @@
#include <linux/errno.h>
#include <linux/kernel.h>
#include <linux/init.h>
+#include <linux/io.h>
#include <linux/ioport.h>
#include <linux/mutex.h>
#include <linux/nsc_gpio.h>
#include <linux/platform_device.h>
#include <asm/uaccess.h>
-#include <asm/io.h>
#define DEVNAME "pc8736x_gpio"
reply other threads:[~2006-06-22 18:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449AE6C2.3090905@gmail.com \
--to=jim.cromie@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.