From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] fix linux ioremap() of domain local memory
Date: Sun, 25 Jun 2006 13:17:34 +0300
Message-ID: <449E62BE.9080301@qumranet.com>
References: <449ADC86.4070902@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <449ADC86.4070902@qumranet.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Avi Kivity wrote:
> is_local_lowmem() treats its physical address input as a machine 
> address; this causes agpgart to fail while calling ioremap_nocache().
>
> X still does not load on my Athlon 64 / Via S3 Unichrome, so perhaps 
> best not to apply just yet.

This is bogus: ioremap_nocache() does accept machine addresses, but 
x86_64 agpgart passes it a physical address.  This is because x86_64 
lacks the address translation bits:

--- /dev/null   2006-06-25 13:08:55.714359750 +0300
+++ include/asm-x86_64/mach-xen/asm/agp.h       2006-06-25 13:15:12.000000000 +0300
@@ -0,0 +1 @@
+#include "../../../asm-i386/mach-xen/asm/agp.h"


Still locks up hard when starting up X, but now the gart table is 
remapped correctly at least.

-- 
error compiling committee.c: too many arguments to function