From: Nick Piggin <nickpiggin@yahoo.com.au>
To: David Howells <dhowells@redhat.com>
Cc: Neil Brown <neilb@suse.de>,
balbir@in.ibm.com, akpm@osdl.org, aviro@redhat.com,
jblunck@suse.de, dev@openvz.org, olh@suse.de,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Destroy the dentries contributed by a superblock on unmounting
Date: Mon, 26 Jun 2006 02:30:34 +1000 [thread overview]
Message-ID: <449EBA2A.5030501@yahoo.com.au> (raw)
In-Reply-To: <20946.1151251352@warthog.cambridge.redhat.com>
David Howells wrote:
> + for (;;) {
> + /* descend to the first leaf in the current subtree */
> + while (!list_empty(&dentry->d_subdirs)) {
> + /* this dentry has children - pin it whilst we dispose
> + * of them */
> + atomic_inc(&dentry->d_count);
> + dentry = list_entry(dentry->d_subdirs.next,
> + struct dentry, d_u.d_child);
> + }
> +
> + consume_empty_leaf:
Just to nitpick, the indented label goes against the style in this
part of the kernel.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-06-25 16:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 12:22 [PATCH] Fix dcache race during umount David Howells
2006-06-22 14:27 ` David Howells
2006-06-22 16:08 ` Jan Blunck
2006-06-22 16:44 ` Jan Blunck
2006-06-23 13:28 ` Jan Blunck
2006-06-24 5:23 ` Neil Brown
2006-06-24 9:16 ` David Howells
2006-06-24 13:33 ` [PATCH] Destroy the dentries contributed by a superblock on unmounting David Howells
2006-06-25 6:48 ` Neil Brown
2006-06-25 16:02 ` David Howells
2006-06-25 16:30 ` Nick Piggin [this message]
2006-06-26 6:05 ` Neil Brown
2006-06-26 11:21 ` David Howells
2006-06-27 0:53 ` Neil Brown
2006-06-27 10:17 ` David Howells
2006-06-27 22:55 ` Andrew Morton
2006-06-27 23:18 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449EBA2A.5030501@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=aviro@redhat.com \
--cc=balbir@in.ibm.com \
--cc=dev@openvz.org \
--cc=dhowells@redhat.com \
--cc=jblunck@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.