From: Tejun Heo <htejun@gmail.com>
To: "zhao, forrest" <forrest.zhao@intel.com>
Cc: jgarzik@pobox.com, lkml@rtr.ca, axboe@suse.de,
alan@lxorguk.ukuu.org.uk, linux-ide@vger.kernel.org
Subject: Re: [PATCHSET] [PATCHSET] new Power Management for libata, take 2
Date: Mon, 26 Jun 2006 17:17:54 +0900 [thread overview]
Message-ID: <449F9832.7050107@gmail.com> (raw)
In-Reply-To: <1151305792.7132.184.camel@forrest26.sh.intel.com>
zhao, forrest wrote:
> On Mon, 2006-06-26 at 16:11 +0900, Tejun Heo wrote:
>> Will do after this whole thing get reviewed. I don't know much about
>> ACPI but don't we need to do it regardless of LLDs? If so, I think it
>> might be better to hook those directly into ata_eh_suspend/resume().
>
> in ata_eh_suspend/resume(), all operations are device-level. We need a
> port-level function inside ata_eh_suspend/resume(), and inside this
> port-level function both generic port-level operations and LLD specific
> port-level callbacks are called.
Then, please create a separate hook. It can be just side by side w/
ops->suspend/resume() calls but I think they need to be called
separately from LLD-specific PM ops.
--
tejun
next prev parent reply other threads:[~2006-06-26 8:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-24 11:30 [PATCHSET] [PATCHSET] new Power Management for libata, take 2 Tejun Heo
2006-06-24 11:30 ` [PATCH 02/15] libata: implement and use ata_deh_dev_action() Tejun Heo
2006-06-24 11:30 ` [PATCH 01/15] libata: move ata_eh_clear_action() upward Tejun Heo
2006-06-27 1:00 ` Jeff Garzik
2006-06-24 11:30 ` [PATCH 03/15] libata: clear EH action on device detach Tejun Heo
2006-06-24 11:30 ` [PATCH 08/15] libata: implement PM EH actions Tejun Heo
2006-06-24 11:30 ` [PATCH 07/15] libata: implement ata_port_max_devices() Tejun Heo
2006-06-24 11:30 ` [PATCH 05/15] libata: update ata_do_simple_cmd() Tejun Heo
2006-06-24 11:30 ` [PATCH 04/15] libata: move ata_do_simple_cmd() below ata_exec_internal() Tejun Heo
2006-06-24 11:30 ` [PATCH 09/15] libata: reimplement per-dev PM Tejun Heo
2006-06-24 11:30 ` [PATCH 06/15] libata: make two functions global Tejun Heo
2006-06-24 11:30 ` [PATCH 12/15] sata_sil: separate out sil_init_controller() Tejun Heo
2006-06-24 11:30 ` [PATCH 15/15] sata_sil24: add suspend/sleep support Tejun Heo
2006-06-24 11:30 ` [PATCH 13/15] sata_sil: " Tejun Heo
2006-06-24 11:30 ` [PATCH 10/15] libata: move ata_flush_cache() from libata-core.c to libata-eh.c Tejun Heo
2006-06-24 11:30 ` [PATCH 14/15] sata_sil24: separate out sil24_init_controller() Tejun Heo
2006-06-24 11:30 ` [PATCH 11/15] libata: reimplement controller-wide PM Tejun Heo
2006-06-26 6:36 ` zhao, forrest
2006-06-26 6:53 ` Tejun Heo
2006-06-24 11:36 ` [git-patch] new Power Management for libata, take 2 Tejun Heo
2006-06-26 6:42 ` [PATCHSET] [PATCHSET] " zhao, forrest
2006-06-26 6:58 ` Tejun Heo
2006-06-26 6:49 ` zhao, forrest
2006-06-26 7:11 ` Tejun Heo
2006-06-26 7:09 ` zhao, forrest
2006-06-26 8:17 ` Tejun Heo [this message]
2006-06-26 7:20 ` Jeff Garzik
2006-06-26 8:15 ` Tejun Heo
2006-06-26 8:09 ` zhao, forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449F9832.7050107@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=forrest.zhao@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.