From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com,
xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
consulting@bugseng.com, jbeulich@suse.com,
andrew.cooper3@citrix.com, roger.pau@citrix.com,
tamas@tklengyel.com
Subject: Re: [XEN PATCH 3/6] x86/vm_event: add missing include
Date: Sat, 12 Aug 2023 11:53:44 +0200 [thread overview]
Message-ID: <449fa348676e754b7eae9b8acc00fb86@bugseng.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2308111600190.2127516@ubuntu-linux-20-04-desktop>
>> diff --git a/xen/arch/x86/vm_event.c b/xen/arch/x86/vm_event.c
>> index 7027c08a926b..499b6b349d79 100644
>> --- a/xen/arch/x86/vm_event.c
>> +++ b/xen/arch/x86/vm_event.c
>> @@ -20,6 +20,7 @@
>>
>> #include <xen/sched.h>
>> #include <xen/mem_access.h>
>> +#include <xen/vm_event.h>
>> #include <asm/vm_event.h>
>>
>> /* Implicitly serialized by the domctl lock. */
>
> I think the problem here is that ./arch/x86/include/asm/vm_event.h,
> differently from ./arch/arm/include/asm/vm_event.h, doesn't #include
> <xen/vm_event.h>
I see your point. Do you think it would be better to include
xen/vm_event.h
in asm/vm_event.h for x86 or move the inclusion of xen/vm_event.h for
arm to
the source file, as done in the patch?
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
next prev parent reply other threads:[~2023-08-12 9:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 7:19 [XEN PATCH 0/6] xen: fix missing headers and static storage duration Nicola Vetrini
2023-08-11 7:19 ` [XEN PATCH 1/6] x86/hpet: make variable 'per_cpu__cpu_bc_channel' static Nicola Vetrini
2023-08-11 22:54 ` Stefano Stabellini
2023-08-11 22:55 ` Stefano Stabellini
2023-08-14 7:34 ` Jan Beulich
2023-08-11 7:19 ` [XEN PATCH 2/6] x86/setup: add missing headers Nicola Vetrini
2023-08-11 22:58 ` Stefano Stabellini
2023-08-14 7:38 ` Jan Beulich
2023-08-14 7:43 ` Nicola Vetrini
2023-08-11 7:19 ` [XEN PATCH 3/6] x86/vm_event: add missing include Nicola Vetrini
2023-08-11 23:01 ` Stefano Stabellini
2023-08-12 9:53 ` Nicola Vetrini [this message]
2023-08-12 11:37 ` Julien Grall
2023-08-14 7:16 ` Jan Beulich
2023-08-14 7:39 ` Jan Beulich
2023-08-14 10:33 ` Nicola Vetrini
2023-08-14 11:01 ` Julien Grall
2023-08-14 12:53 ` Nicola Vetrini
2023-08-14 13:06 ` Julien Grall
2023-08-14 13:31 ` Jan Beulich
2023-08-14 13:47 ` Julien Grall
2023-08-14 12:57 ` Nicola Vetrini
2023-08-11 7:19 ` [XEN PATCH 4/6] cpufreq: add missing include of header 'pmstat.h' Nicola Vetrini
2023-08-11 23:03 ` Stefano Stabellini
2023-08-14 7:41 ` Jan Beulich
2023-08-11 7:19 ` [XEN PATCH 5/6] vpic/msix: make 'get_slot' static Nicola Vetrini
2023-08-11 23:03 ` Stefano Stabellini
2023-08-14 7:44 ` Jan Beulich
2023-08-14 7:54 ` Nicola Vetrini
2023-08-11 7:19 ` [XEN PATCH 6/6] drivers/video: make declarations of defined functions available Nicola Vetrini
2023-08-11 23:09 ` Stefano Stabellini
2023-08-14 7:47 ` Jan Beulich
2023-08-14 7:56 ` Nicola Vetrini
2023-08-14 8:12 ` Jan Beulich
2023-08-14 9:28 ` Nicola Vetrini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449fa348676e754b7eae9b8acc00fb86@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=andrew.cooper3@citrix.com \
--cc=ayan.kumar.halder@amd.com \
--cc=consulting@bugseng.com \
--cc=jbeulich@suse.com \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.