All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Hefty <mshefty@ichips.intel.com>
To: Eric Sesterhenn <snakebyte@gmx.de>,
	Roland Dreier <rdreier@cisco.com>,
	torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Array overrun in drivers/infiniband/core/cma.c
Date: Mon, 26 Jun 2006 11:24:02 -0700	[thread overview]
Message-ID: <44A02642.2030308@ichips.intel.com> (raw)
In-Reply-To: <1150916186.23613.1.camel@alice>

Eric Sesterhenn wrote:
> this was spotted by coverity #id 1300. Since
> the array has only four elements, we should 
> just use those four.
> 
> Patch is against todays git tree.
> 
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

Acked-by: Sean Hefty <sean.hefty@intel.com>

please apply Eric's patch below

> --- linux-2.6/drivers/infiniband/core/cma.c.orig	2006-06-21 20:54:10.000000000 +0200
> +++ linux-2.6/drivers/infiniband/core/cma.c	2006-06-21 20:54:22.000000000 +0200
> @@ -476,7 +476,7 @@ static inline int cma_zero_addr(struct s
>  	else {
>  		ip6 = &((struct sockaddr_in6 *) addr)->sin6_addr;
>  		return (ip6->s6_addr32[0] | ip6->s6_addr32[1] |
> -			ip6->s6_addr32[3] | ip6->s6_addr32[4]) == 0;
> +			ip6->s6_addr32[2] | ip6->s6_addr32[3]) == 0;
>  	}
>  }
>  
> 


      reply	other threads:[~2006-06-26 18:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 18:56 [Patch] Array overrun in drivers/infiniband/core/cma.c Eric Sesterhenn
2006-06-26 18:24 ` Sean Hefty [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44A02642.2030308@ichips.intel.com \
    --to=mshefty@ichips.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=snakebyte@gmx.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.