All of lore.kernel.org
 help / color / mirror / Atom feed
From: r.marek@sh.cvut.cz (Rudolf Marek)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] W83627EHF driver update
Date: Mon, 26 Jun 2006 20:34:46 +0000	[thread overview]
Message-ID: <44A044E6.1080204@sh.cvut.cz> (raw)
In-Reply-To: <4485CB7A.9050209@sh.cvut.cz>

Hi Jean,

> The temp <-> pwm mapping standard already exists.

Aha ok. pwm[1-*]_auto_channels_temp I guess.

>>> But the driver uncondionally creates both files? This needs to be
>>> investigated, and fixed (either the driver or the documentation.)
>> I fixed the note. The files are used in SF3 iirc, so we might have them.
> 
> I'm still not exactly happy. Documenting that we implemented things in
> a possibly non-working way is better than not documenting it, agreed,
> but even better would be to have things working in the first place.

This stuff is so complex that even if you think you got it right, then some bits 
will make even bigger mess than it was.

> Also on the to do list is the export of the fan <-> temperature
> mapping, at least read only, as I asked before already. For now pwm4 is
> useless in Temperature Cruise mode, as you don't know what temperature
> channel it is working with.

pwm4 is disabled on my board so I cannot tell which is which. I remmber that on 
david board it is disabled too.

I will put this into my queue, do it soon.

> Anyway, I will apply these patches now, as we have gone trough many
> review cycles already. I made some fixes to the documentation patch to
> fix typos and reword one sentence. Any future change to the w83627ehf
> driver or its documentation should be incremental on top of these
> patches.

Thank you very much. As you know I'm not in exactly good situation so I hope I 
will do better next time when things are sorted out.

Regards
Rudolf


      parent reply	other threads:[~2006-06-26 20:34 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-06 18:37 [lm-sensors] [PATCH] W83627EHF driver update Rudolf Marek
2006-06-06 21:02 ` David Hubbard
2006-06-07 10:29 ` Jim Cromie
2006-06-07 20:51 ` David Hubbard
2006-06-07 21:00 ` Rudolf Marek
2006-06-07 21:06 ` Rudolf Marek
2006-06-07 22:13 ` Sylvain Jeaugey
2006-06-08  1:01 ` David Hubbard
2006-06-08  7:51 ` Sylvain Jeaugey
2006-06-12 16:30 ` Jean Delvare
2006-06-12 23:12 ` David Hubbard
2006-06-13  8:53 ` Jean Delvare
2006-06-13 16:03 ` David Hubbard
2006-06-14 12:48 ` Rudolf Marek
2006-06-14 15:06 ` Jean Delvare
2006-06-14 15:14 ` Rudolf Marek
2006-06-14 15:50 ` Jean Delvare
2006-06-14 21:29 ` Rudolf Marek
2006-06-15 14:55 ` David Hubbard
2006-06-15 15:20 ` Sylvain Jeaugey
2006-06-16  4:29 ` David Hubbard
2006-06-16 21:33 ` Rudolf Marek
2006-06-19 15:53 ` David Hubbard
2006-06-20 12:41 ` Jean Delvare
2006-06-21 15:10 ` David Hubbard
2006-06-24 16:42 ` Rudolf Marek
2006-06-25 14:04 ` Jean Delvare
2006-06-25 16:00 ` Rudolf Marek
2006-06-26 19:33 ` Jean Delvare
2006-06-26 20:34 ` Rudolf Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44A044E6.1080204@sh.cvut.cz \
    --to=r.marek@sh.cvut.cz \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.