From: Andy Whitcroft <apw@shadowen.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
Toralf Foerster <toralf.foerster@gmx.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Chuck Ebbert <76306.1226@compuserve.com>,
"Randy.Dunlap" <rdunlap@xenotime.net>
Subject: Re: linux-2.6.17.1: undefined reference to `online_page'
Date: Tue, 27 Jun 2006 13:10:55 +0100 [thread overview]
Message-ID: <44A1204F.3070704@shadowen.org> (raw)
In-Reply-To: <1151343992.10877.34.camel@localhost.localdomain>
Dave Hansen wrote:
> On Mon, 2006-06-26 at 16:39 +0900, Yasunori Goto wrote:
>
>>===================================================================
>>--- linux-2.6.17.orig/mm/Kconfig 2006-06-26 14:19:11.000000000
>>+0900
>>+++ linux-2.6.17/mm/Kconfig 2006-06-26 14:19:53.000000000 +0900
>>@@ -115,7 +115,7 @@ config SPARSEMEM_EXTREME
>> # eventually, we can have this option just 'select SPARSEMEM'
>> config MEMORY_HOTPLUG
>> bool "Allow for memory hot-add"
>>- depends on SPARSEMEM && HOTPLUG && !SOFTWARE_SUSPEND
>>+ depends on SPARSEMEM && HOTPLUG && !SOFTWARE_SUSPEND
>>&& !(X86_32 && !HIGHMEM)
>>
>> comment "Memory hotplug is currently incompatible with Software
>>Suspend"
>> depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND
>
>
> I think it makes a lot more sense to just disable sparsemem when !
> HIGHMEM. Plus, we can do all of that in the arch-specific Kconfigs and
> not litter the generic ones with this stuff.
SPARSEMEM cirtainly isn't going to offer you anything much with this
little memory. If you were going to do this I'd say it makes more sense
to introduce an ARCH_DISABLE_MEMORY_HOTPLUG sort of thing and add that
in the x86 Kconfig.
-apw
next prev parent reply other threads:[~2006-06-27 12:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-25 21:01 linux-2.6.17.1: undefined reference to `online_page' Chuck Ebbert
2006-06-25 21:23 ` Randy.Dunlap
2006-06-26 7:39 ` Yasunori Goto
2006-06-26 17:46 ` Dave Hansen
2006-06-27 11:55 ` Yasunori Goto
2006-06-27 12:10 ` Andy Whitcroft [this message]
2006-06-28 2:27 ` Yasunori Goto
2006-06-29 3:21 ` [PATCH] solve config broken: " Yasunori Goto
2006-06-29 14:58 ` Dave Hansen
2006-06-30 2:14 ` Chris Wright
2006-06-30 2:20 ` Chris Wright
-- strict thread matches above, loose matches on Subject: below --
2006-06-23 8:01 linux-2.6.17.1: " Toralf Förster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A1204F.3070704@shadowen.org \
--to=apw@shadowen.org \
--cc=76306.1226@compuserve.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=toralf.foerster@gmx.de \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.