From: Jeff Garzik <jeff@garzik.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use dev_printk() in some net drivers
Date: Tue, 27 Jun 2006 11:41:09 -0400 [thread overview]
Message-ID: <44A15195.8060506@garzik.org> (raw)
In-Reply-To: <44A14A5F.3090607@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 103 bytes --]
Jiri Slaby wrote:
> Don't you consider to use s#dev_printk(KERN_ERR, #dev_err(# macro?
Done.
Jeff
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 27754 bytes --]
685aa11f7f1de42802cb0a8d5816c1efb08f65cd
diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c
index c38e352..2f3fb2e 100644
--- a/drivers/net/8139cp.c
+++ b/drivers/net/8139cp.c
@@ -1837,11 +1837,10 @@ #endif
if (pdev->vendor == PCI_VENDOR_ID_REALTEK &&
pdev->device == PCI_DEVICE_ID_REALTEK_8139 && pci_rev < 0x20) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"This (id %04x:%04x rev %02x) is not an 8139C+ compatible chip\n",
pdev->vendor, pdev->device, pci_rev);
- dev_printk(KERN_ERR, &pdev->dev,
- "Try the \"8139too\" driver instead.\n");
+ dev_err(&pdev->dev, "Try the \"8139too\" driver instead.\n");
return -ENODEV;
}
@@ -1879,13 +1878,12 @@ #endif
pciaddr = pci_resource_start(pdev, 1);
if (!pciaddr) {
rc = -EIO;
- dev_printk(KERN_ERR, &pdev->dev, "no MMIO resource\n");
+ dev_err(&pdev->dev, "no MMIO resource\n");
goto err_out_res;
}
if (pci_resource_len(pdev, 1) < CP_REGS_SIZE) {
rc = -EIO;
- dev_printk(KERN_ERR, &pdev->dev,
- "MMIO resource (%lx) too small\n",
+ dev_err(&pdev->dev, "MMIO resource (%lx) too small\n",
pci_resource_len(pdev, 1));
goto err_out_res;
}
@@ -1900,13 +1898,13 @@ #endif
rc = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
if (rc) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"No usable DMA configuration, aborting.\n");
goto err_out_res;
}
rc = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);
if (rc) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"No usable consistent DMA configuration, "
"aborting.\n");
goto err_out_res;
@@ -1919,8 +1917,7 @@ #endif
regs = ioremap(pciaddr, CP_REGS_SIZE);
if (!regs) {
rc = -EIO;
- dev_printk(KERN_ERR, &pdev->dev,
- "Cannot map PCI MMIO (%lx@%lx)\n",
+ dev_err(&pdev->dev, "Cannot map PCI MMIO (%lx@%lx)\n",
pci_resource_len(pdev, 1), pciaddr);
goto err_out_res;
}
diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c
index b2592c4..173e59e 100644
--- a/drivers/net/8139too.c
+++ b/drivers/net/8139too.c
@@ -769,8 +769,7 @@ static int __devinit rtl8139_init_board
/* dev and priv zeroed in alloc_etherdev */
dev = alloc_etherdev (sizeof (*tp));
if (dev == NULL) {
- dev_printk (KERN_ERR, &pdev->dev,
- "Unable to alloc new net device\n");
+ dev_err(&pdev->dev, "Unable to alloc new net device\n");
return -ENOMEM;
}
SET_MODULE_OWNER(dev);
@@ -802,29 +801,25 @@ static int __devinit rtl8139_init_board
#ifdef USE_IO_OPS
/* make sure PCI base addr 0 is PIO */
if (!(pio_flags & IORESOURCE_IO)) {
- dev_printk (KERN_ERR, &pdev->dev,
- "region #0 not a PIO resource, aborting\n");
+ dev_err(&pdev->dev, "region #0 not a PIO resource, aborting\n");
rc = -ENODEV;
goto err_out;
}
/* check for weird/broken PCI region reporting */
if (pio_len < RTL_MIN_IO_SIZE) {
- dev_printk (KERN_ERR, &pdev->dev,
- "Invalid PCI I/O region size(s), aborting\n");
+ dev_err(&pdev->dev, "Invalid PCI I/O region size(s), aborting\n");
rc = -ENODEV;
goto err_out;
}
#else
/* make sure PCI base addr 1 is MMIO */
if (!(mmio_flags & IORESOURCE_MEM)) {
- dev_printk (KERN_ERR, &pdev->dev,
- "region #1 not an MMIO resource, aborting\n");
+ dev_err(&pdev->dev, "region #1 not an MMIO resource, aborting\n");
rc = -ENODEV;
goto err_out;
}
if (mmio_len < RTL_MIN_IO_SIZE) {
- dev_printk (KERN_ERR, &pdev->dev,
- "Invalid PCI mem region size(s), aborting\n");
+ dev_err(&pdev->dev, "Invalid PCI mem region size(s), aborting\n");
rc = -ENODEV;
goto err_out;
}
@@ -841,7 +836,7 @@ #endif
#ifdef USE_IO_OPS
ioaddr = ioport_map(pio_start, pio_len);
if (!ioaddr) {
- dev_printk (KERN_ERR, &pdev->dev, "cannot map PIO, aborting\n");
+ dev_err(&pdev->dev, "cannot map PIO, aborting\n");
rc = -EIO;
goto err_out;
}
@@ -852,8 +847,7 @@ #else
/* ioremap MMIO region */
ioaddr = pci_iomap(pdev, 1, 0);
if (ioaddr == NULL) {
- dev_printk (KERN_ERR, &pdev->dev,
- "cannot remap MMIO, aborting\n");
+ dev_err(&pdev->dev, "cannot remap MMIO, aborting\n");
rc = -EIO;
goto err_out;
}
@@ -867,8 +861,7 @@ #endif /* USE_IO_OPS */
/* check for missing/broken hardware */
if (RTL_R32 (TxConfig) == 0xFFFFFFFF) {
- dev_printk (KERN_ERR, &pdev->dev,
- "Chip not responding, ignoring board\n");
+ dev_err(&pdev->dev, "Chip not responding, ignoring board\n");
rc = -EIO;
goto err_out;
}
@@ -962,10 +955,10 @@ #endif
if (pdev->vendor == PCI_VENDOR_ID_REALTEK &&
pdev->device == PCI_DEVICE_ID_REALTEK_8139 && pci_rev >= 0x20) {
- dev_printk(KERN_INFO, &pdev->dev,
+ dev_info(&pdev->dev,
"This (id %04x:%04x rev %02x) is an enhanced 8139C+ chip\n",
pdev->vendor, pdev->device, pci_rev);
- dev_printk(KERN_INFO, &pdev->dev,
+ dev_info(&pdev->dev,
"Use the \"8139cp\" driver for improved performance and stability.\n");
}
diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index 6d7748d..9fce7e6 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
@@ -2120,13 +2120,13 @@ static int __devinit b44_init_one(struct
err = pci_enable_device(pdev);
if (err) {
- dev_printk(KERN_ERR, &pdev->dev, "Cannot enable PCI device, "
+ dev_err(&pdev->dev, "Cannot enable PCI device, "
"aborting.\n");
return err;
}
if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM)) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"Cannot find proper PCI device "
"base address, aborting.\n");
err = -ENODEV;
@@ -2135,7 +2135,7 @@ static int __devinit b44_init_one(struct
err = pci_request_regions(pdev, DRV_MODULE_NAME);
if (err) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"Cannot obtain PCI resources, aborting.\n");
goto err_out_disable_pdev;
}
@@ -2144,15 +2144,13 @@ static int __devinit b44_init_one(struct
err = pci_set_dma_mask(pdev, (u64) B44_DMA_MASK);
if (err) {
- dev_printk(KERN_ERR, &pdev->dev,
- "No usable DMA configuration, aborting.\n");
+ dev_err(&pdev->dev, "No usable DMA configuration, aborting.\n");
goto err_out_free_res;
}
err = pci_set_consistent_dma_mask(pdev, (u64) B44_DMA_MASK);
if (err) {
- dev_printk(KERN_ERR, &pdev->dev,
- "No usable DMA configuration, aborting.\n");
+ dev_err(&pdev->dev, "No usable DMA configuration, aborting.\n");
goto err_out_free_res;
}
@@ -2161,8 +2159,7 @@ static int __devinit b44_init_one(struct
dev = alloc_etherdev(sizeof(*bp));
if (!dev) {
- dev_printk(KERN_ERR, &pdev->dev,
- "Etherdev alloc failed, aborting.\n");
+ dev_err(&pdev->dev, "Etherdev alloc failed, aborting.\n");
err = -ENOMEM;
goto err_out_free_res;
}
@@ -2183,8 +2180,7 @@ static int __devinit b44_init_one(struct
bp->regs = ioremap(b44reg_base, b44reg_len);
if (bp->regs == 0UL) {
- dev_printk(KERN_ERR, &pdev->dev, "Cannot map device registers, "
- "aborting.\n");
+ dev_err(&pdev->dev, "Cannot map device registers, aborting.\n");
err = -ENOMEM;
goto err_out_free_dev;
}
@@ -2214,7 +2210,7 @@ #endif
err = b44_get_invariants(bp);
if (err) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"Problem fetching invariants of chip, aborting.\n");
goto err_out_iounmap;
}
@@ -2235,8 +2231,7 @@ #endif
err = register_netdev(dev);
if (err) {
- dev_printk(KERN_ERR, &pdev->dev, "Cannot register net device, "
- "aborting.\n");
+ dev_err(&pdev->dev, "Cannot register net device, aborting.\n");
goto err_out_iounmap;
}
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 171e498..152de92 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -5566,13 +5566,12 @@ bnx2_init_board(struct pci_dev *pdev, st
/* enable device (incl. PCI PM wakeup), and bus-mastering */
rc = pci_enable_device(pdev);
if (rc) {
- dev_printk(KERN_ERR, &pdev->dev,
- "Cannot enable PCI device, aborting.");
+ dev_err(&pdev->dev, "Cannot enable PCI device, aborting.");
goto err_out;
}
if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM)) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"Cannot find PCI device base address, aborting.\n");
rc = -ENODEV;
goto err_out_disable;
@@ -5580,8 +5579,7 @@ bnx2_init_board(struct pci_dev *pdev, st
rc = pci_request_regions(pdev, DRV_MODULE_NAME);
if (rc) {
- dev_printk(KERN_ERR, &pdev->dev,
- "Cannot obtain PCI resources, aborting.\n");
+ dev_err(&pdev->dev, "Cannot obtain PCI resources, aborting.\n");
goto err_out_disable;
}
@@ -5589,7 +5587,7 @@ bnx2_init_board(struct pci_dev *pdev, st
bp->pm_cap = pci_find_capability(pdev, PCI_CAP_ID_PM);
if (bp->pm_cap == 0) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"Cannot find power management capability, aborting.\n");
rc = -EIO;
goto err_out_release;
@@ -5597,8 +5595,7 @@ bnx2_init_board(struct pci_dev *pdev, st
bp->pcix_cap = pci_find_capability(pdev, PCI_CAP_ID_PCIX);
if (bp->pcix_cap == 0) {
- dev_printk(KERN_ERR, &pdev->dev,
- "Cannot find PCIX capability, aborting.\n");
+ dev_err(&pdev->dev, "Cannot find PCIX capability, aborting.\n");
rc = -EIO;
goto err_out_release;
}
@@ -5606,15 +5603,14 @@ bnx2_init_board(struct pci_dev *pdev, st
if (pci_set_dma_mask(pdev, DMA_64BIT_MASK) == 0) {
bp->flags |= USING_DAC_FLAG;
if (pci_set_consistent_dma_mask(pdev, DMA_64BIT_MASK) != 0) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"pci_set_consistent_dma_mask failed, aborting.\n");
rc = -EIO;
goto err_out_release;
}
}
else if (pci_set_dma_mask(pdev, DMA_32BIT_MASK) != 0) {
- dev_printk(KERN_ERR, &pdev->dev,
- "System does not support DMA, aborting.\n");
+ dev_err(&pdev->dev, "System does not support DMA, aborting.\n");
rc = -EIO;
goto err_out_release;
}
@@ -5634,8 +5630,7 @@ bnx2_init_board(struct pci_dev *pdev, st
bp->regview = ioremap_nocache(dev->base_addr, mem_len);
if (!bp->regview) {
- dev_printk(KERN_ERR, &pdev->dev,
- "Cannot map register space, aborting.\n");
+ dev_err(&pdev->dev, "Cannot map register space, aborting.\n");
rc = -ENOMEM;
goto err_out_release;
}
@@ -5707,7 +5702,7 @@ bnx2_init_board(struct pci_dev *pdev, st
else if ((CHIP_ID(bp) == CHIP_ID_5706_A1) &&
!(bp->flags & PCIX_FLAG)) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"5706 A1 can only be used in a PCIX bus, aborting.\n");
goto err_out_unmap;
}
@@ -5729,8 +5724,7 @@ bnx2_init_board(struct pci_dev *pdev, st
if ((reg & BNX2_DEV_INFO_SIGNATURE_MAGIC_MASK) !=
BNX2_DEV_INFO_SIGNATURE_MAGIC) {
- dev_printk(KERN_ERR, &pdev->dev,
- "Firmware not running, aborting.\n");
+ dev_err(&pdev->dev, "Firmware not running, aborting.\n");
rc = -ENODEV;
goto err_out_unmap;
}
@@ -5892,8 +5886,7 @@ #if defined(HAVE_POLL_CONTROLLER) || def
#endif
if ((rc = register_netdev(dev))) {
- dev_printk(KERN_ERR, &pdev->dev,
- "Cannot register net device\n");
+ dev_err(&pdev->dev, "Cannot register net device\n");
if (bp->regview)
iounmap(bp->regview);
pci_release_regions(pdev);
diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c
index ccff239..79ea9db 100644
--- a/drivers/net/cassini.c
+++ b/drivers/net/cassini.c
@@ -4888,13 +4888,12 @@ static int __devinit cas_init_one(struct
err = pci_enable_device(pdev);
if (err) {
- dev_printk(KERN_ERR, &pdev->dev, "Cannot enable PCI device, "
- "aborting.\n");
+ dev_err(&pdev->dev, "Cannot enable PCI device, aborting.\n");
return err;
}
if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM)) {
- dev_printk(KERN_ERR, &pdev->dev, "Cannot find proper PCI device "
+ dev_err(&pdev->dev, "Cannot find proper PCI device "
"base address, aborting.\n");
err = -ENODEV;
goto err_out_disable_pdev;
@@ -4902,7 +4901,7 @@ static int __devinit cas_init_one(struct
dev = alloc_etherdev(sizeof(*cp));
if (!dev) {
- dev_printk(KERN_ERR, &pdev->dev, "Etherdev alloc failed, aborting.\n");
+ dev_err(&pdev->dev, "Etherdev alloc failed, aborting.\n");
err = -ENOMEM;
goto err_out_disable_pdev;
}
@@ -4911,8 +4910,7 @@ static int __devinit cas_init_one(struct
err = pci_request_regions(pdev, dev->name);
if (err) {
- dev_printk(KERN_ERR, &pdev->dev, "Cannot obtain PCI resources, "
- "aborting.\n");
+ dev_err(&pdev->dev, "Cannot obtain PCI resources, aborting.\n");
goto err_out_free_netdev;
}
pci_set_master(pdev);
@@ -4942,7 +4940,7 @@ #if 1
if (pci_write_config_byte(pdev,
PCI_CACHE_LINE_SIZE,
cas_cacheline_size)) {
- dev_printk(KERN_ERR, &pdev->dev, "Could not set PCI cache "
+ dev_err(&pdev->dev, "Could not set PCI cache "
"line size\n");
goto err_write_cacheline;
}
@@ -4956,7 +4954,7 @@ #endif
err = pci_set_consistent_dma_mask(pdev,
DMA_64BIT_MASK);
if (err < 0) {
- dev_printk(KERN_ERR, &pdev->dev, "Unable to obtain 64-bit DMA "
+ dev_err(&pdev->dev, "Unable to obtain 64-bit DMA "
"for consistent allocations\n");
goto err_out_free_res;
}
@@ -4964,7 +4962,7 @@ #endif
} else {
err = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
if (err) {
- dev_printk(KERN_ERR, &pdev->dev, "No usable DMA configuration, "
+ dev_err(&pdev->dev, "No usable DMA configuration, "
"aborting.\n");
goto err_out_free_res;
}
@@ -5024,8 +5022,7 @@ #endif
/* give us access to cassini registers */
cp->regs = pci_iomap(pdev, 0, casreg_len);
if (cp->regs == 0UL) {
- dev_printk(KERN_ERR, &pdev->dev, "Cannot map device registers, "
- "aborting.\n");
+ dev_err(&pdev->dev, "Cannot map device registers, aborting.\n");
goto err_out_free_res;
}
cp->casreg_len = casreg_len;
@@ -5041,8 +5038,7 @@ #endif
pci_alloc_consistent(pdev, sizeof(struct cas_init_block),
&cp->block_dvma);
if (!cp->init_block) {
- dev_printk(KERN_ERR, &pdev->dev, "Cannot allocate init block, "
- "aborting.\n");
+ dev_err(&pdev->dev, "Cannot allocate init block, aborting.\n");
goto err_out_iounmap;
}
@@ -5086,8 +5082,7 @@ #endif
dev->features |= NETIF_F_HIGHDMA;
if (register_netdev(dev)) {
- dev_printk(KERN_ERR, &pdev->dev, "Cannot register net device, "
- "aborting.\n");
+ dev_err(&pdev->dev, "Cannot register net device, aborting.\n");
goto err_out_free_consistent;
}
diff --git a/drivers/net/eepro100.c b/drivers/net/eepro100.c
index 0b65a31..7795de6 100644
--- a/drivers/net/eepro100.c
+++ b/drivers/net/eepro100.c
@@ -556,14 +556,12 @@ #endif
if (!request_region(pci_resource_start(pdev, 1),
pci_resource_len(pdev, 1), "eepro100")) {
- dev_printk (KERN_ERR, &pdev->dev,
- "eepro100: cannot reserve I/O ports\n");
+ dev_err(&pdev->dev, "eepro100: cannot reserve I/O ports\n");
goto err_out_none;
}
if (!request_mem_region(pci_resource_start(pdev, 0),
pci_resource_len(pdev, 0), "eepro100")) {
- dev_printk (KERN_ERR, &pdev->dev,
- "eepro100: cannot reserve MMIO region\n");
+ dev_err(&pdev->dev, "eepro100: cannot reserve MMIO region\n");
goto err_out_free_pio_region;
}
@@ -576,7 +574,7 @@ #endif
ioaddr = pci_iomap(pdev, pci_bar, 0);
if (!ioaddr) {
- dev_printk (KERN_ERR, &pdev->dev, "eepro100: cannot remap IO\n");
+ dev_err(&pdev->dev, "eepro100: cannot remap IO\n");
goto err_out_free_mmio_region;
}
diff --git a/drivers/net/epic100.c b/drivers/net/epic100.c
index 1ec06a5..7c1240d 100644
--- a/drivers/net/epic100.c
+++ b/drivers/net/epic100.c
@@ -336,7 +336,7 @@ #endif
irq = pdev->irq;
if (pci_resource_len(pdev, 0) < EPIC_TOTAL_SIZE) {
- dev_printk(KERN_ERR, &pdev->dev, "no PCI region space\n");
+ dev_err(&pdev->dev, "no PCI region space\n");
ret = -ENODEV;
goto err_out_disable;
}
@@ -351,7 +351,7 @@ #endif
dev = alloc_etherdev(sizeof (*ep));
if (!dev) {
- dev_printk(KERN_ERR, &pdev->dev, "no memory for eth device\n");
+ dev_err(&pdev->dev, "no memory for eth device\n");
goto err_out_free_res;
}
SET_MODULE_OWNER(dev);
@@ -363,7 +363,7 @@ #else
ioaddr = pci_resource_start (pdev, 1);
ioaddr = (long) ioremap (ioaddr, pci_resource_len (pdev, 1));
if (!ioaddr) {
- dev_printk(KERN_ERR, &pdev->dev, "ioremap failed\n");
+ dev_err(&pdev->dev, "ioremap failed\n");
goto err_out_free_netdev;
}
#endif
@@ -445,7 +445,7 @@ #endif
int mii_status = mdio_read(dev, phy, MII_BMSR);
if (mii_status != 0xffff && mii_status != 0x0000) {
ep->phys[phy_idx++] = phy;
- dev_printk(KERN_INFO, &pdev->dev,
+ dev_info(&pdev->dev,
"MII transceiver #%d control "
"%4.4x status %4.4x.\n",
phy, mdio_read(dev, phy, 0), mii_status);
@@ -455,12 +455,12 @@ #endif
if (phy_idx != 0) {
phy = ep->phys[0];
ep->mii.advertising = mdio_read(dev, phy, MII_ADVERTISE);
- dev_printk(KERN_INFO, &pdev->dev,
+ dev_info(&pdev->dev,
"Autonegotiation advertising %4.4x link "
"partner %4.4x.\n",
ep->mii.advertising, mdio_read(dev, phy, 5));
} else if ( ! (ep->chip_flags & NO_MII)) {
- dev_printk(KERN_WARNING, &pdev->dev,
+ dev_warn(&pdev->dev,
"***WARNING***: No MII transceiver found!\n");
/* Use the known PHY address of the EPII. */
ep->phys[0] = 3;
@@ -476,8 +476,7 @@ #endif
/* The lower four bits are the media type. */
if (duplex) {
ep->mii.force_media = ep->mii.full_duplex = 1;
- dev_printk(KERN_INFO, &pdev->dev,
- "Forced full duplex operation requested.\n");
+ dev_info(&pdev->dev, "Forced full duplex requested.\n");
}
dev->if_port = ep->default_port = option;
diff --git a/drivers/net/fealnx.c b/drivers/net/fealnx.c
index 9369082..e2955ee 100644
--- a/drivers/net/fealnx.c
+++ b/drivers/net/fealnx.c
@@ -505,7 +505,7 @@ #endif
len = pci_resource_len(pdev, bar);
if (len < MIN_REGION_SIZE) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"region size %ld too small, aborting\n", len);
return -ENODEV;
}
@@ -578,7 +578,7 @@ #endif
if (mii_status != 0xffff && mii_status != 0x0000) {
np->phys[phy_idx++] = phy;
- dev_printk(KERN_INFO, &pdev->dev,
+ dev_info(&pdev->dev,
"MII PHY found at address %d, status "
"0x%4.4x.\n", phy, mii_status);
/* get phy type */
@@ -604,7 +604,7 @@ #endif
np->mii_cnt = phy_idx;
if (phy_idx == 0)
- dev_printk(KERN_WARNING, &pdev->dev,
+ dev_warn(&pdev->dev,
"MII PHY not found -- this device may "
"not operate correctly.\n");
} else {
@@ -632,8 +632,7 @@ #endif
np->mii.full_duplex = full_duplex[card_idx];
if (np->mii.full_duplex) {
- dev_printk(KERN_INFO, &pdev->dev,
- "Media type forced to Full Duplex.\n");
+ dev_info(&pdev->dev, "Media type forced to Full Duplex.\n");
/* 89/6/13 add, (begin) */
// if (np->PHYType==MarvellPHY)
if ((np->PHYType == MarvellPHY) || (np->PHYType == LevelOnePHY)) {
diff --git a/drivers/net/ne2k-pci.c b/drivers/net/ne2k-pci.c
index b5bf53f..7b808da 100644
--- a/drivers/net/ne2k-pci.c
+++ b/drivers/net/ne2k-pci.c
@@ -231,14 +231,12 @@ #endif
irq = pdev->irq;
if (!ioaddr || ((pci_resource_flags (pdev, 0) & IORESOURCE_IO) == 0)) {
- dev_printk (KERN_ERR, &pdev->dev,
- "no I/O resource at PCI BAR #0\n");
+ dev_err(&pdev->dev, "no I/O resource at PCI BAR #0\n");
return -ENODEV;
}
if (request_region (ioaddr, NE_IO_EXTENT, DRV_NAME) == NULL) {
- dev_printk (KERN_ERR, &pdev->dev,
- "I/O resource 0x%x @ 0x%lx busy\n",
+ dev_err(&pdev->dev, "I/O resource 0x%x @ 0x%lx busy\n",
NE_IO_EXTENT, ioaddr);
return -EBUSY;
}
@@ -265,8 +263,7 @@ #endif
/* Allocate net_device, dev->priv; fill in 8390 specific dev fields. */
dev = alloc_ei_netdev();
if (!dev) {
- dev_printk (KERN_ERR, &pdev->dev,
- "cannot allocate ethernet device\n");
+ dev_err(&pdev->dev, "cannot allocate ethernet device\n");
goto err_out_free_res;
}
SET_MODULE_OWNER(dev);
@@ -284,7 +281,7 @@ #endif
while ((inb(ioaddr + EN0_ISR) & ENISR_RESET) == 0)
/* Limit wait: '2' avoids jiffy roll-over. */
if (jiffies - reset_start_time > 2) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"Card failure (no reset ack).\n");
goto err_out_free_netdev;
}
diff --git a/drivers/net/ns83820.c b/drivers/net/ns83820.c
index 916ec99..7ab2ab7 100644
--- a/drivers/net/ns83820.c
+++ b/drivers/net/ns83820.c
@@ -1833,8 +1833,7 @@ static int __devinit ns83820_init_one(st
} else if (!pci_set_dma_mask(pci_dev, DMA_32BIT_MASK)) {
using_dac = 0;
} else {
- dev_printk(KERN_WARNING, &pci_dev->dev,
- "pci_set_dma_mask failed!\n");
+ dev_warn(&pci_dev->dev, "pci_set_dma_mask failed!\n");
return -ENODEV;
}
@@ -1857,8 +1856,7 @@ static int __devinit ns83820_init_one(st
err = pci_enable_device(pci_dev);
if (err) {
- dev_printk(KERN_INFO, &pci_dev->dev,
- "pci_enable_dev failed: %d\n", err);
+ dev_info(&pci_dev->dev, "pci_enable_dev failed: %d\n", err);
goto out_free;
}
@@ -1887,8 +1885,7 @@ static int __devinit ns83820_init_one(st
err = request_irq(pci_dev->irq, ns83820_irq, SA_SHIRQ,
DRV_NAME, ndev);
if (err) {
- dev_printk(KERN_INFO, &pci_dev->dev,
- "unable to register irq %d, err %d\n",
+ dev_info(&pci_dev->dev, "unable to register irq %d, err %d\n",
pci_dev->irq, err);
goto out_disable;
}
@@ -1903,8 +1900,7 @@ static int __devinit ns83820_init_one(st
rtnl_lock();
err = dev_alloc_name(ndev, ndev->name);
if (err < 0) {
- dev_printk(KERN_INFO, &pci_dev->dev,
- "unable to get netdev name: %d\n", err);
+ dev_info(&pci_dev->dev, "unable to get netdev name: %d\n", err);
goto out_free_irq;
}
diff --git a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c
index 2754fad..71c1bfe 100644
--- a/drivers/net/pci-skeleton.c
+++ b/drivers/net/pci-skeleton.c
@@ -602,8 +602,7 @@ static int __devinit netdrv_init_board (
/* dev zeroed in alloc_etherdev */
dev = alloc_etherdev (sizeof (*tp));
if (dev == NULL) {
- dev_printk (KERN_ERR, &pdev->dev,
- "unable to alloc new ethernet\n");
+ dev_err(&pdev->dev, "unable to alloc new ethernet\n");
DPRINTK ("EXIT, returning -ENOMEM\n");
return -ENOMEM;
}
@@ -633,16 +632,14 @@ static int __devinit netdrv_init_board (
/* make sure PCI base addr 0 is PIO */
if (!(pio_flags & IORESOURCE_IO)) {
- dev_printk (KERN_ERR, &pdev->dev,
- "region #0 not a PIO resource, aborting\n");
+ dev_err(&pdev->dev, "region #0 not a PIO resource, aborting\n");
rc = -ENODEV;
goto err_out;
}
/* make sure PCI base addr 1 is MMIO */
if (!(mmio_flags & IORESOURCE_MEM)) {
- dev_printk (KERN_ERR, &pdev->dev,
- "region #1 not an MMIO resource, aborting\n");
+ dev_err(&pdev->dev, "region #1 not an MMIO resource, aborting\n");
rc = -ENODEV;
goto err_out;
}
@@ -650,8 +647,7 @@ static int __devinit netdrv_init_board (
/* check for weird/broken PCI region reporting */
if ((pio_len < NETDRV_MIN_IO_SIZE) ||
(mmio_len < NETDRV_MIN_IO_SIZE)) {
- dev_printk (KERN_ERR, &pdev->dev,
- "Invalid PCI region size(s), aborting\n");
+ dev_err(&pdev->dev, "Invalid PCI region size(s), aborting\n");
rc = -ENODEV;
goto err_out;
}
@@ -668,8 +664,7 @@ #else
/* ioremap MMIO region */
ioaddr = ioremap (mmio_start, mmio_len);
if (ioaddr == NULL) {
- dev_printk (KERN_ERR, &pdev->dev,
- "cannot remap MMIO, aborting\n");
+ dev_err(&pdev->dev, "cannot remap MMIO, aborting\n");
rc = -EIO;
goto err_out_free_res;
}
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 24a5b31..a9d227f 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1406,8 +1406,7 @@ rtl8169_init_board(struct pci_dev *pdev,
dev = alloc_etherdev(sizeof (*tp));
if (dev == NULL) {
if (netif_msg_drv(&debug))
- dev_printk(KERN_ERR, &pdev->dev,
- "unable to alloc new ethernet\n");
+ dev_err(&pdev->dev, "unable to alloc new ethernet\n");
goto err_out;
}
@@ -1420,7 +1419,7 @@ rtl8169_init_board(struct pci_dev *pdev,
rc = pci_enable_device(pdev);
if (rc < 0) {
if (netif_msg_probe(tp))
- dev_printk(KERN_ERR, &pdev->dev, "enable failure\n");
+ dev_err(&pdev->dev, "enable failure\n");
goto err_out_free_dev;
}
@@ -1437,14 +1436,14 @@ rtl8169_init_board(struct pci_dev *pdev,
acpi_idle_state = pwr_command & PCI_PM_CTRL_STATE_MASK;
} else {
if (netif_msg_probe(tp))
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"PowerManagement capability not found.\n");
}
/* make sure PCI base addr 1 is MMIO */
if (!(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) {
if (netif_msg_probe(tp))
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"region #1 not an MMIO resource, aborting\n");
rc = -ENODEV;
goto err_out_mwi;
@@ -1452,7 +1451,7 @@ rtl8169_init_board(struct pci_dev *pdev,
/* check for weird/broken PCI region reporting */
if (pci_resource_len(pdev, 1) < R8169_REGS_SIZE) {
if (netif_msg_probe(tp))
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"Invalid PCI region size(s), aborting\n");
rc = -ENODEV;
goto err_out_mwi;
@@ -1461,8 +1460,7 @@ rtl8169_init_board(struct pci_dev *pdev,
rc = pci_request_regions(pdev, MODULENAME);
if (rc < 0) {
if (netif_msg_probe(tp))
- dev_printk(KERN_ERR, &pdev->dev,
- "could not request regions.\n");
+ dev_err(&pdev->dev, "could not request regions.\n");
goto err_out_mwi;
}
@@ -1476,7 +1474,7 @@ rtl8169_init_board(struct pci_dev *pdev,
rc = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
if (rc < 0) {
if (netif_msg_probe(tp))
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"DMA configuration failed.\n");
goto err_out_free_res;
}
@@ -1488,8 +1486,7 @@ rtl8169_init_board(struct pci_dev *pdev,
ioaddr = ioremap(pci_resource_start(pdev, 1), R8169_REGS_SIZE);
if (ioaddr == NULL) {
if (netif_msg_probe(tp))
- dev_printk(KERN_ERR, &pdev->dev,
- "cannot remap MMIO, aborting\n");
+ dev_err(&pdev->dev, "cannot remap MMIO, aborting\n");
rc = -EIO;
goto err_out_free_res;
}
diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 7412400..b0cb56d 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -697,14 +697,14 @@ static int __devinit velocity_found1(str
* can support more than MAX_UNITS.
*/
if (velocity_nics >= MAX_UNITS) {
- dev_printk(KERN_NOTICE, &pdev->dev, "already found %d NICs.\n",
+ dev_notice(&pdev->dev, "already found %d NICs.\n",
velocity_nics);
return -ENODEV;
}
dev = alloc_etherdev(sizeof(struct velocity_info));
if (!dev) {
- dev_printk(KERN_ERR, &pdev->dev, "allocate net device failed.\n");
+ dev_err(&pdev->dev, "allocate net device failed.\n");
goto out;
}
@@ -741,7 +741,7 @@ static int __devinit velocity_found1(str
ret = pci_request_regions(pdev, VELOCITY_NAME);
if (ret < 0) {
- dev_printk(KERN_ERR, &pdev->dev, "No PCI resources.\n");
+ dev_err(&pdev->dev, "No PCI resources.\n");
goto err_disable;
}
@@ -897,19 +897,19 @@ static int __devinit velocity_get_pci_in
vptr->memaddr = pci_resource_start(pdev, 1);
if (!(pci_resource_flags(pdev, 0) & IORESOURCE_IO)) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"region #0 is not an I/O resource, aborting.\n");
return -EINVAL;
}
if ((pci_resource_flags(pdev, 1) & IORESOURCE_IO)) {
- dev_printk(KERN_ERR, &pdev->dev,
+ dev_err(&pdev->dev,
"region #1 is an I/O resource, aborting.\n");
return -EINVAL;
}
if (pci_resource_len(pdev, 1) < VELOCITY_IO_SIZE) {
- dev_printk(KERN_ERR, &pdev->dev, "region #1 is too small.\n");
+ dev_err(&pdev->dev, "region #1 is too small.\n");
return -EINVAL;
}
vptr->pdev = pdev;
prev parent reply other threads:[~2006-06-27 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 14:51 [PATCH] use dev_printk() in some net drivers Jeff Garzik
2006-06-27 15:10 ` Jiri Slaby
2006-06-27 15:13 ` Jeff Garzik
2006-06-27 15:41 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A15195.8060506@garzik.org \
--to=jeff@garzik.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.