From: Auke Kok <auke-jan.h.kok@intel.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: netdev@vger.kernel.org, john.ronciak@intel.com,
jesse.brandeburg@intel.com, jeffrey.t.kirsher@intel.com, "Zhang,
Yanmin" <yanmin.zhang@intel.com>, Jeff Garzik <jgarzik@pobox.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: e1000: Janitor: Use #defined values for literals
Date: Tue, 27 Jun 2006 11:03:17 -0700 [thread overview]
Message-ID: <44A172E5.1030905@intel.com> (raw)
In-Reply-To: <20060627173224.GA31770@austin.ibm.com>
Linas Vepstas wrote:
> On Fri, Jun 23, 2006 at 01:07:21PM -0700, Auke Kok wrote:
>> Linas Vepstas wrote:
>>> Minor janitorial patch: use #defines for literal values.
>>> + pci_enable_wake(pdev, PCI_D3hot, 0);
>>> + pci_enable_wake(pdev, PCI_D3cold, 0);
>> I Acked this but that's silly - the patches sent yesterday already change
>> the code above and this patch is no longer needed (thanks Jesse for
>> spotting this).
>>
>> This patch would conflict with them so please don't apply.
>
> Maybe there's a backlog in the queue, but I not this is not
> yet in 2.6.17-mm3
It's part of the submission for 2.6.18 I sent to jgarzik on friday, which
cleans up this section in the way.
Auke
next prev parent reply other threads:[~2006-06-27 18:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 16:36 [PATCH]: e1000: Janitor: Use #defined values for literals Linas Vepstas
2006-06-23 18:07 ` Auke Kok
2006-06-23 20:07 ` Auke Kok
2006-06-23 21:12 ` Linas Vepstas
2006-06-27 17:32 ` Linas Vepstas
2006-06-27 18:03 ` Auke Kok [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-07 20:16 Linas Vepstas
2006-08-07 20:21 ` Auke Kok
2006-08-07 20:29 ` Jeff Garzik
2006-09-25 22:30 Linas Vepstas
2006-09-25 23:13 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A172E5.1030905@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.