From: Albert Lee <albertcc@tw.ibm.com>
To: Linux IDE <linux-ide@vger.kernel.org>
Subject: [PATCH 1/2] libata-dev: pata_pdc2027x minor fix for new EH
Date: Wed, 28 Jun 2006 14:40:35 +0800 [thread overview]
Message-ID: <44A22463.6050607@tw.ibm.com> (raw)
Changes:
- move the function pointers around for better grouping
- remove the unused ->eng_timeout()
- add ->freeze(), ->thaw() and ->post_internal_cmd() for UDMA133 pdc adapters.
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
---
Patch against the pata-drivers branch (0ab56aae451577586ecac6968d86251a83f1cb40)
(0.74-ac3). For your review, thanks.
--- pata/drivers/scsi/pata_pdc2027x.c 2006-06-27 18:25:14.000000000 +0800
+++ 01_pdc074-eh/drivers/scsi/pata_pdc2027x.c 2006-06-28 13:40:38.000000000 +0800
@@ -154,11 +154,6 @@ static struct ata_port_operations pdc202
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,
- .freeze = ata_bmdma_freeze,
- .thaw = ata_bmdma_thaw,
- .error_handler = pdc2027x_error_handler,
- .post_internal_cmd = ata_bmdma_post_internal_cmd,
-
.check_atapi_dma = pdc2027x_check_atapi_dma,
.bmdma_setup = ata_bmdma_setup,
.bmdma_start = ata_bmdma_start,
@@ -166,9 +161,13 @@ static struct ata_port_operations pdc202
.bmdma_status = ata_bmdma_status,
.qc_prep = ata_qc_prep,
.qc_issue = ata_qc_issue_prot,
- .eng_timeout = ata_eng_timeout,
.data_xfer = ata_mmio_data_xfer,
+ .freeze = ata_bmdma_freeze,
+ .thaw = ata_bmdma_thaw,
+ .error_handler = pdc2027x_error_handler,
+ .post_internal_cmd = ata_bmdma_post_internal_cmd,
+
.irq_handler = ata_interrupt,
.irq_clear = ata_bmdma_irq_clear,
@@ -181,6 +180,7 @@ static struct ata_port_operations pdc202
.port_disable = ata_port_disable,
.set_piomode = pdc2027x_set_piomode,
.set_dmamode = pdc2027x_set_dmamode,
+ .post_set_mode = pdc2027x_post_set_mode,
.tf_load = ata_tf_load,
.tf_read = ata_tf_read,
@@ -188,9 +188,6 @@ static struct ata_port_operations pdc202
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,
- .error_handler = pdc2027x_error_handler,
- .post_set_mode = pdc2027x_post_set_mode,
-
.check_atapi_dma = pdc2027x_check_atapi_dma,
.bmdma_setup = ata_bmdma_setup,
.bmdma_start = ata_bmdma_start,
@@ -198,9 +195,13 @@ static struct ata_port_operations pdc202
.bmdma_status = ata_bmdma_status,
.qc_prep = ata_qc_prep,
.qc_issue = ata_qc_issue_prot,
- .eng_timeout = ata_eng_timeout,
.data_xfer = ata_mmio_data_xfer,
+ .freeze = ata_bmdma_freeze,
+ .thaw = ata_bmdma_thaw,
+ .error_handler = pdc2027x_error_handler,
+ .post_internal_cmd = ata_bmdma_post_internal_cmd,
+
.irq_handler = ata_interrupt,
.irq_clear = ata_bmdma_irq_clear,
reply other threads:[~2006-06-28 6:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A22463.6050607@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=albertl@mail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.