From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] linux/x86: Initialize high_memory as early as possible Date: Thu, 29 Jun 2006 16:03:38 +0200 Message-ID: <44A3F9DA.76E4.0078.0@novell.com> References: <44A3F4DB.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 29.06.06 15:55 >>> > >On 29 Jun 2006, at 14:42, Jan Beulich wrote: > >> Also all other variables dependent on the same input(s). This is a >> prerequisite patch for two ones to follow. I will >> post a similar change for mainline Linux soon. >> >> Signed-off-by: jbeulich@novell.com > >Is this just for the usage in kunmap_atomic? Why did you change that, Not only, also for the added check in xen_{create,destroy}_contiguous_region in another of the patches just sent. >by the way: FIXADDR_START looked like a safe enough test to me. This didn't seem safe enough to me, and apparently also not to the original author (at least I attribute the FIXME comment to this) - after all not everything before FIXADDR_START is high memory. One could say that under DEBUG_HIGHMEM the check should be more strict (so that the subsequent BUG() condition fires in more broken cases), but without DEBUG_HIGHMEM it might be left as-is to avoid zapping incorrect page table entries. Jan