From: Tejun Heo <htejun@gmail.com>
To: Borislav Petkov <bbpetkov@yahoo.de>
Cc: linux-ide <linux-ide@vger.kernel.org>, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH 3/9] ata_piix.c conversion
Date: Fri, 30 Jun 2006 01:32:24 +0900 [thread overview]
Message-ID: <44A40098.5050303@gmail.com> (raw)
In-Reply-To: <20060629160952.GD23122@zmei.tnic>
Borislav Petkov wrote:
> @@ -515,7 +515,8 @@ static int piix_sata_prereset(struct ata
> u8 pcs;
>
> pci_read_config_byte(pdev, ICH5_PCS, &pcs);
> - DPRINTK("ata%u: ENTER, pcs=0x%x base=%d\n", ap->id, pcs, base);
> + ata_port_printk(ap, ATA_MSG_CMD,
> + "ata%u: ENTER, pcs=0x%x base=%d\n", ap->id, pcs, base);
Again, not CMD.
>
> /* enable all ports on this ap and wait for them to settle */
> for (i = 0; i < 2; i++) {
> @@ -544,11 +545,11 @@ static int piix_sata_prereset(struct ata
> if (!(ap->flags & PIIX_FLAG_AHCI))
> pci_write_config_byte(pdev, ICH5_PCS, pcs);
>
> - DPRINTK("ata%u: LEAVE, pcs=0x%x present_mask=0x%x\n",
> + ata_port_printk(ap, ATA_MSG_CMD, "ata%u: LEAVE, pcs=0x%x present_mask=0x%x\n",
> ap->id, pcs, present_mask);
Ditto.
> @@ -642,7 +643,7 @@ static void piix_set_dmamode (struct ata
> u8 reg48, reg54, reg55;
>
> pci_read_config_word(dev, maslave, ®4042);
> - DPRINTK("reg4042 = 0x%04x\n", reg4042);
> + ata_port_printk(ap, ATA_MSG_CMD, "reg4042 = 0x%04x\n", reg4042);
Ditto.
--
tejun
next prev parent reply other threads:[~2006-06-29 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-29 16:09 [PATCH 3/9] ata_piix.c conversion Borislav Petkov
2006-06-29 16:32 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-30 6:46 Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A40098.5050303@gmail.com \
--to=htejun@gmail.com \
--cc=bbpetkov@yahoo.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.