From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Ericsson Subject: Re: [PATCH] autoconf: Use autoconf to write installation directories to config.mak Date: Fri, 30 Jun 2006 14:18:27 +0200 Message-ID: <44A51693.5020501@op5.se> References: <200606290301.51657.jnareb@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org X-From: git-owner@vger.kernel.org Fri Jun 30 14:18:33 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FwHxA-0005Ln-S7 for gcvg-git@gmane.org; Fri, 30 Jun 2006 14:18:33 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932220AbWF3MS3 (ORCPT ); Fri, 30 Jun 2006 08:18:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932460AbWF3MS3 (ORCPT ); Fri, 30 Jun 2006 08:18:29 -0400 Received: from linux-server1.op5.se ([193.201.96.2]:63454 "EHLO smtp-gw1.op5.se") by vger.kernel.org with ESMTP id S932220AbWF3MS2 (ORCPT ); Fri, 30 Jun 2006 08:18:28 -0400 Received: from [192.168.1.20] (unknown [213.88.215.14]) by smtp-gw1.op5.se (Postfix) with ESMTP id 4E4F06BCC0; Fri, 30 Jun 2006 14:18:27 +0200 (CEST) User-Agent: Mozilla Thunderbird 1.0.8-1.1.fc4 (X11/20060501) X-Accept-Language: en-us, en To: Jakub Narebski In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Jakub Narebski wrote: > Matthias Lederhofer wrote: > > >>>This is beginning of patch series introducing installation configuration >>>using autoconf (and no other autotools) to git. The idea is to generate >>>config.mak using ./configure (generated from configure.ac) from >>>config.mak.in, so one can use autoconf as an _alternative_ to ordinary >>>Makefile, and creating one's own config.mak. >> >>Are you sure this should be named config.mak? From INSTALL: >> >>>You can place local settings in config.mak and the Makefile >>>will include them. Note that config.mak is not distributed; >>>the name is reserved for local settings. >> >>So with another filename either include it >>- before config.mak: the user may override ./configure options with >> config.mak >>- after config.mak: ./configure overrides config.mak > > > The idea was to use ./configure to _generate_ config.mak, which the user can > then edit. > This is bad, since it forces users to do one thing first and then do what they're used to. Better to have the script add -include config.mak.autogen LAST in config.mak, unless it's already in the file and generate config.mak.autogen with configure. Since Make does things bottoms-up (much like swedish students and midsummer celebrators), the previous hand-edited defaults in config.mak will beat the ones in config.mak.autogen (a good thing). > But perhaps using another filename for results of ./configure script > (and including it in main Makefile) would be better idea. > > >>At least do not overwrite config.mak if it exists. > > > But one might want to run ./configure with different options, to finally > arrive at the set which is satisfactionary. So unless some magic to detect > if config.mak was generated from ./configure script, or generated by user > is used... > grep -q autogen config.mak || \ echo "-include config.mak.autogen" >> config.mak I wouldn't want my long-standing, functioning config.mak overwritten, but I *might* be interested in trying some of the options provided by ./configure. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231