From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Ofsthun Subject: Re: [PATCH - proposed] XI Shadow Page Table Mechanism] Date: Fri, 30 Jun 2006 09:33:19 -0400 Message-ID: <44A5281F.5090407@virtualiron.com> References: <44A3CA74.4000206@virtualiron.com> <44A3D3CE.3040408@virtualiron.com> <44A3E08B.9090103@gmail.com> <44A3E98B.9040602@virtualiron.com> <44A3F073.50305@virtualiron.com> <44A48E5C.8060609@gmail.com> <44A51DE9.1020909@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Robert Phillips Cc: zhu , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Robert Phillips wrote: > Yes, that's true. If the caller supplied a bogus PFN (one larger than > ram size), we'd crash. > BTW, we are avoiding use of grant table transfers because they fragment > PSE pages. > -- rsp We also avoid grant table transfers due to incompatibilities with QEMU's one time map of all of guest memory. If you use grant table transfers (via netfront/netback), the QEMU memory map quickly becomes out of date. Any QEMU I/O (net, or disk), will result in stale guest data being used. > On 6/30/06, *zhu* > > wrote: > > I'm afraid it could trigger some certain problems only when you open l2 > PSE flag and use grant table to transfer pages between domains. I'm not > very sure about it. :-) > > _______________________________________________________ > Best Regards, > hanzhu > > > Robert Phillips 写道: > > Hi Han, > > You are right again. I have not seen this cause a problem but we'll > > certainly fix it. > > -- rsp > > > > On 6/29/06, zhu < vanbas.han@gmail.com > > wrote: > >> > >> Hi, Robert, > >> I found out another confusing code snippet: > >> in void xi_invl_mfn(struct domain *d, unsigned long mfn) > >> if (ext && pfn < ext->large_page_aligned_size) > >> > >> According to the code, it should be > >> if (ext && (pfn>>SPT_ENTRIES_ORDER) < > ext->large_page_aligned_size) > >> > >> If I made any mistake, please point it out. > >> _______________________________________________________ > >> Best Regards, > >> hanzhu > >> > > > > > > > > > -- > -------------------------------------------------------------------- > Robert S. Phillips Virtual Iron Software > rphillips@virtualiron.com > Tower 1, Floor 2 > 978-849-1220 900 Chelmsford Street > Lowell, MA 01851 > > > ------------------------------------------------------------------------ > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel -- Steve Ofsthun - Virtual Iron Software, Inc.