2.6.17.1 compile error with a netfilter module

2.6.17.1 compile error with a netfilter module

[Greg Scott]

Does anyone know what this means and how to fix it?  I know it looks
like a file named lockhelp.h is missing.  I guess my question is, what
can I do to fix it?

With this build, I tried to put in some POM patches from
patch-o-matic-ng-20060624.  Could this have been my problem? 

.

.

.

  CC [M]  net/ipv4/ipvs/ip_vs_nq.o
  CC [M]  net/ipv4/ipvs/ip_vs_ftp.o
scripts/Makefile.build:52: kbuild: net/ipv4/netfilter/Makefile - Usage
of 
export-objs is obsolete in 2.6. Please fix!
  LD      net/ipv4/netfilter/built-in.o
  CC [M]  net/ipv4/netfilter/ip_conntrack_standalone.o
In file included from include/linux/netfilter_ipv4/ip_conntrack.h:32,
                 from net/ipv4/netfilter/ip_conntrack_standalone.c:35:
include/linux/netfilter_ipv4/ip_conntrack_talk.h:7:43: error: 
linux/netfilter_ipv4/lockhelp.h: No such file or directory
In file included from include/linux/netfilter_ipv4/ip_conntrack.h:32,
                 from net/ipv4/netfilter/ip_conntrack_standalone.c:35:
include/linux/netfilter_ipv4/ip_conntrack_talk.h:10: warning: data
definition has no 
type or storage class
include/linux/netfilter_ipv4/ip_conntrack_talk.h:10: warning: type
defaults to 'int' 
in declaration of 'DECLARE_LOCK_EXTERN'
include/linux/netfilter_ipv4/ip_conntrack_talk.h:10: warning: parameter
names 
(without types) in function declaration
make[3]: *** [net/ipv4/netfilter/ip_conntrack_standalone.o] Error 1
make[2]: *** [net/ipv4/netfilter] Error 2
make[1]: *** [net/ipv4] Error 2
make: *** [net] Error 2
You have new mail in /var/spool/mail/root
[root@HHHC-fw linux]#
[root@HHHC-fw linux]#
[


thanks

- Greg Scott

Re: 2.6.17.1 compile error with a netfilter module

[Patrick McHardy]

Greg Scott wrote:
> Does anyone know what this means and how to fix it?  I know it looks
> like a file named lockhelp.h is missing.  I guess my question is, what
> can I do to fix it?
> 
> With this build, I tried to put in some POM patches from
> patch-o-matic-ng-20060624.  Could this have been my problem? 

Yes. It looks like you managed to apply some old 2.4 patches :)
If you don't need them I'd suggest to just don't use them.

RE: 2.6.17.1 compile error with a netfilter module

[Greg Scott]

Hmmm -

Here are the POM modules I tried to use:

Base
  connlimit		
  iprange	 
  time
Extra
  comment
  IPMARK
  ipp2p		
  ROUTE
  sip-conntrack-nat

Of these, the runme script for connlimit, iprange, comment, and IPMARM
blew up with 
errors like this:

./runme --batch connlimit
(Blows up with this error:
unable to find ladd slot in src
/tmp/pom-15223/net/ipv4/netfilter/Makefile 
(./patchlets/connlimit/linux-2.6.11/./net/ipv4/netfilter/Makefile.ladd)
-----------------------------------------------------------------
Do you want to apply this patch [N/y/t/f/a/r/b/w/q/?] y
unable to find ladd slot in src
/tmp/pom-15223/net/ipv4/netfilter/Makefile 
(./patchlets/connlimit/linux-2.6.11/./net/ipv4/netfilter/Makefile.ladd)
-
./runme --batch iprange
(Blows up with the same error as above)
#
./runme --batch comment
(Blows up and then asks about more modules)

./runme --batch IPMARK
(Blows up same as above)

Expanding the latest POM dated 20060629, it looks like the latest
connlimit is more than a year old. 
iprange has a linux tree with ipt_iprange.c dated 2003 and another one
from 2004 in linux-2.6.
comment isn't even in the 20060629 snapshot.  

The modules for IPMARK look like they are dated Jan 21 of this year.  
One of the time modules is dated March 29 of this year.
Most of the ipp2p modules look like they are dated March 29 of this
year.
It looks like ROUTE had some ipv6 work recently.  The ipv4 stuff is a
little bit old.
sip-conntrack-nat has a 2.6.13 tree.  The modules are dated May and July
2005.  

I'll try another build, this time with 2.6.17.2 and POM 20060629 using
these POM 
modules:
  time
  ipp2p
  ROUTE
  sip-conntrack-nat

These are the ones that did not generate any errors with the runme
script last time.  

I'll post the results here in a couple of hours.

- Greg Scott




-----Original Message-----
From: Patrick McHardy [mailto:kaber@trash.net] 
Sent: Friday, June 30, 2006 10:28 AM
To: Greg Scott
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: 2.6.17.1 compile error with a netfilter module


Greg Scott wrote:
> Does anyone know what this means and how to fix it?  I know it looks 
> like a file named lockhelp.h is missing.  I guess my question is, what

> can I do to fix it?
> 
> With this build, I tried to put in some POM patches from 
> patch-o-matic-ng-20060624.  Could this have been my problem?

Yes. It looks like you managed to apply some old 2.4 patches :) If you
don't need them I'd suggest to just don't use them.

RE: 2.6.17.1 compile error with a netfilter module

[Torsten Luettgert]

On Fri, 2006-06-30 at 12:36 -0500, Greg Scott wrote:
> Hmmm -

> I'll try another build, this time with 2.6.17.2 and POM 20060629 using
> these POM 
> modules:
>   time
>   ipp2p
>   ROUTE
>   sip-conntrack-nat

time, ipp2p and ROUTE won't work with 2.6.17 without API patches -
I posted those last saturday, but they didn't get committed yet.
You can grab them from the archives. Don't know about sip-conntrack-nat,
but I suspect it'll have the same problem.

Regards,
Torsten

RE: 2.6.17.1 compile error with a netfilter module

[Greg Scott]

Bummer!  My kernel build went error free this time.  Took about an hour
on a 1Ghz system.  Does anyone have an idea when the API patches will be
committed?

Thanks

- Greg


-----Original Message-----
From: Torsten Luettgert [mailto:t.luettgert@pressestimmen.de] 
Sent: Friday, June 30, 2006 3:55 PM
To: Greg Scott
Cc: netfilter-devel@lists.netfilter.org
Subject: RE: 2.6.17.1 compile error with a netfilter module


On Fri, 2006-06-30 at 12:36 -0500, Greg Scott wrote:
> Hmmm -

> I'll try another build, this time with 2.6.17.2 and POM 20060629 using

> these POM
> modules:
>   time
>   ipp2p
>   ROUTE
>   sip-conntrack-nat

time, ipp2p and ROUTE won't work with 2.6.17 without API patches - I
posted those last saturday, but they didn't get committed yet. You can
grab them from the archives. Don't know about sip-conntrack-nat, but I
suspect it'll have the same problem.

Regards,
Torsten

Re: 2.6.17.1 compile error with a netfilter module

[Patrick McHardy]

Torsten Luettgert wrote:
> On Fri, 2006-06-30 at 12:36 -0500, Greg Scott wrote:
> 
>>Hmmm -
> 
> 
>>I'll try another build, this time with 2.6.17.2 and POM 20060629 using
>>these POM 
>>modules:
>>  time
>>  ipp2p
>>  ROUTE
>>  sip-conntrack-nat
> 
> 
> time, ipp2p and ROUTE won't work with 2.6.17 without API patches -
> I posted those last saturday, but they didn't get committed yet.
> You can grab them from the archives. Don't know about sip-conntrack-nat,
> but I suspect it'll have the same problem.

Just applied ROUTE and u32. I think Jozsef already fixed u32, the
remaining patchlets are not part of official pomng anymore, although
I still haven't received the URL of the new external repository.

Re: 2.6.17.1 compile error with a netfilter module

[Krzysztof Oledzki]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 966 bytes --]



On Mon, 3 Jul 2006, Patrick McHardy wrote:

> Torsten Luettgert wrote:
>> On Fri, 2006-06-30 at 12:36 -0500, Greg Scott wrote:
>>
>>> Hmmm -
>>
>>
>>> I'll try another build, this time with 2.6.17.2 and POM 20060629 using
>>> these POM
>>> modules:
>>>  time
>>>  ipp2p
>>>  ROUTE
>>>  sip-conntrack-nat
>>
>>
>> time, ipp2p and ROUTE won't work with 2.6.17 without API patches -
>> I posted those last saturday, but they didn't get committed yet.
>> You can grab them from the archives. Don't know about sip-conntrack-nat,
>> but I suspect it'll have the same problem.
>
> Just applied ROUTE and u32. I think Jozsef already fixed u32, the
> remaining patchlets are not part of official pomng anymore, although
> I still haven't received the URL of the new external repository.

Need a day or two, sorry. :( I have been very busy for the last two weeks 
but now I'm going to finish this ASAP.

Best regards,

 				Krzysztof Olędzki

RE: 2.6.17.1 compile error with a netfilter module

[Greg Scott]

Thanks guys.  Meanwhile, I went ahead and built up a box with just the kernel.org 2.6.17.2 kernel and no POM patches for now. 
 
- Greg
 

________________________________

From: Krzysztof Oledzki [mailto:olenf@ans.pl]
Sent: Mon 7/3/2006 2:38 PM
To: Patrick McHardy
Cc: Torsten Luettgert; netfilter-devel@lists.netfilter.org; Greg Scott
Subject: Re: 2.6.17.1 compile error with a netfilter module





On Mon, 3 Jul 2006, Patrick McHardy wrote:

> Torsten Luettgert wrote:
>> On Fri, 2006-06-30 at 12:36 -0500, Greg Scott wrote:
>>
>>> Hmmm -
>>
>>
>>> I'll try another build, this time with 2.6.17.2 and POM 20060629 using
>>> these POM
>>> modules:
>>>  time
>>>  ipp2p
>>>  ROUTE
>>>  sip-conntrack-nat
>>
>>
>> time, ipp2p and ROUTE won't work with 2.6.17 without API patches -
>> I posted those last saturday, but they didn't get committed yet.
>> You can grab them from the archives. Don't know about sip-conntrack-nat,
>> but I suspect it'll have the same problem.
>
> Just applied ROUTE and u32. I think Jozsef already fixed u32, the
> remaining patchlets are not part of official pomng anymore, although
> I still haven't received the URL of the new external repository.

Need a day or two, sorry. :( I have been very busy for the last two weeks
but now I'm going to finish this ASAP.

Best regards,

                                Krzysztof Oledzk 

RE: 2.6.17.1 compile error with a netfilter module

[Krzysztof Oledzki]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1851 bytes --]



On Mon, 3 Jul 2006, Greg Scott wrote:

> Thanks guys.  Meanwhile, I went ahead and built up a box with just the 
> kernel.org 2.6.17.2 kernel and no POM patches for now.

OK, I prepared external repository with correct (I hope!) time and ipp2p 
extensions, TARPIT and connlimit are going to be fixed soon. Before I 
submit this to Patrick I need to be sure that it works. If you would like 
to test it, please:

  - remove "time" and "ipp2p" directories from extracted pom-ng

  - add this to the sources.list:

# ipp2p and time maintained by Krzysztof Oledzki <ole@ans.pl>
http://people.netfilter.org/ole/pom/

  - run "./runme --download"

  - patch & recompile kernel as always

  - tell me if it works (or not).

Both extensions should work with both 2.6.16 and 2.6.17 kernels if I done 
everything properly.

Thanks.

> On Mon, 3 Jul 2006, Patrick McHardy wrote:
>
>> Torsten Luettgert wrote:
>>> On Fri, 2006-06-30 at 12:36 -0500, Greg Scott wrote:
>>>
>>>> Hmmm -
>>>
>>>
>>>> I'll try another build, this time with 2.6.17.2 and POM 20060629 using
>>>> these POM
>>>> modules:
>>>>  time
>>>>  ipp2p
>>>>  ROUTE
>>>>  sip-conntrack-nat
>>>
>>>
>>> time, ipp2p and ROUTE won't work with 2.6.17 without API patches -
>>> I posted those last saturday, but they didn't get committed yet.
>>> You can grab them from the archives. Don't know about sip-conntrack-nat,
>>> but I suspect it'll have the same problem.
>>
>> Just applied ROUTE and u32. I think Jozsef already fixed u32, the
>> remaining patchlets are not part of official pomng anymore, although
>> I still haven't received the URL of the new external repository.
>
> Need a day or two, sorry. :( I have been very busy for the last two weeks
> but now I'm going to finish this ASAP.



Best regards,

 				Krzysztof Olędzki

Re: 2.6.17.1 compile error with a netfilter module

[Patrick McHardy]

Krzysztof Oledzki wrote:
> OK, I prepared external repository with correct (I hope!) time and ipp2p
> extensions, TARPIT and connlimit are going to be fixed soon. Before I
> submit this to Patrick I need to be sure that it works. If you would
> like to test it, please:
> 
>  - remove "time" and "ipp2p" directories from extracted pom-ng
> 
>  - add this to the sources.list:
> 
> # ipp2p and time maintained by Krzysztof Oledzki <ole@ans.pl>
> http://people.netfilter.org/ole/pom/
> 
>  - run "./runme --download"
> 
>  - patch & recompile kernel as always
> 
>  - tell me if it works (or not).
> 
> Both extensions should work with both 2.6.16 and 2.6.17 kernels if I
> done everything properly.

Thanks Krzysztof, seems to work fine (didn't tried patching, but
the rest). I've added it to the sources.list now.

RE: 2.6.17.1 compile error with a netfilter module

[Greg Scott]

Let me try to test it in the field next week.  I am buried all day
today. 

- Greg

-----Original Message-----
From: Patrick McHardy [mailto:kaber@trash.net] 
Sent: Thursday, July 06, 2006 11:14 PM
To: Krzysztof Oledzki
Cc: Greg Scott; Torsten Luettgert; netfilter-devel@lists.netfilter.org
Subject: Re: 2.6.17.1 compile error with a netfilter module

Krzysztof Oledzki wrote:
> OK, I prepared external repository with correct (I hope!) time and 
> ipp2p extensions, TARPIT and connlimit are going to be fixed soon. 
> Before I submit this to Patrick I need to be sure that it works. If 
> you would like to test it, please:
> 
>  - remove "time" and "ipp2p" directories from extracted pom-ng
> 
>  - add this to the sources.list:
> 
> # ipp2p and time maintained by Krzysztof Oledzki <ole@ans.pl> 
> http://people.netfilter.org/ole/pom/
> 
>  - run "./runme --download"
> 
>  - patch & recompile kernel as always
> 
>  - tell me if it works (or not).
> 
> Both extensions should work with both 2.6.16 and 2.6.17 kernels if I 
> done everything properly.

Thanks Krzysztof, seems to work fine (didn't tried patching, but the
rest). I've added it to the sources.list now.