From: Brice Goglin <brice@myri.com>
To: netdev@vger.kernel.org
Cc: brice@myri.com
Subject: [patch 3/4] myri10ge - Use dev_info() when printing parameters after probe
Date: Mon, 03 Jul 2006 18:41:30 -0400 [thread overview]
Message-ID: <44A99D1A.5080301@myri.com> (raw)
In-Reply-To: <20060703220230.606593000@myri.com>
Displaying the interface name when listing the device parameters
at the end of myri10ge_probe is not a good idea since udev might
rename the interface soon afterwards.
Print the bus id instead, using dev_info().
Signed-off-by: Brice Goglin <brice@myri.com>
---
drivers/net/myri10ge/myri10ge.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
Index: linux-mm/drivers/net/myri10ge/myri10ge.c
===================================================================
--- linux-mm.orig/drivers/net/myri10ge/myri10ge.c 2006-07-03 16:02:52.000000000 -0400
+++ linux-mm/drivers/net/myri10ge/myri10ge.c 2006-07-03 16:04:15.000000000 -0400
@@ -2734,11 +2734,10 @@
dev_err(&pdev->dev, "register_netdev failed: %d\n", status);
goto abort_with_irq;
}
-
- printk(KERN_INFO "myri10ge: %s: %s IRQ %d, tx bndry %d, fw %s, WC %s\n",
- netdev->name, (mgp->msi_enabled ? "MSI" : "xPIC"),
- pdev->irq, mgp->tx.boundary, mgp->fw_name,
- (mgp->mtrr >= 0 ? "Enabled" : "Disabled"));
+ dev_info(dev, "%s IRQ %d, tx bndry %d, fw %s, WC %s\n",
+ (mgp->msi_enabled ? "MSI" : "xPIC"),
+ pdev->irq, mgp->tx.boundary, mgp->fw_name,
+ (mgp->mtrr >= 0 ? "Enabled" : "Disabled"));
return 0;
prev parent reply other threads:[~2006-07-03 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 22:02 [patch 0/4] myri10ge minor updates brice
2006-07-03 22:02 ` [patch 1/4] myri10ge - Drop unused pm_state brice
2006-07-03 22:02 ` [patch 2/4] myri10ge - Drop ununsed nvidia chipset id brice
2006-07-03 22:02 ` [patch 3/4] myri10ge - Use dev_info() when printing parameters after probe brice
2006-07-03 22:44 ` Brice Goglin
2006-07-03 22:16 ` [patch 4/4] myri10ge - Export more parameters to ethtool Brice Goglin
2006-07-03 22:41 ` Brice Goglin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A99D1A.5080301@myri.com \
--to=brice@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.