From: Patrick McHardy <kaber@trash.net>
To: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Cc: kernel@linuxace.com, netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] icmpv6 match --icmpv6-type confusion
Date: Tue, 04 Jul 2006 10:21:52 +0200 [thread overview]
Message-ID: <44AA2520.20006@trash.net> (raw)
In-Reply-To: <200607040426.k644QCpQ026660@toshiba.co.jp>
Yasuyuki KOZAKAI wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Tue, 04 Jul 2006 02:46:41 +0200
>
>>I tend to agree with Phil's interpretation that this is actually
>>unexpected behaviour, so I don't think anyone is doing this
>>intentional. I would expect either a parser error or type any.
>
>
> parser error is good idea. It's not neccesary for icmpv6 match to support
> "--icmpv6-type any" because people can get same behavior with only
> "-p ipv6-icmp".
Agreed. Too bad we already have this hack in the kernel for IPv4.
> How about the attached patch ? That also fixes allowing double
> --icmp-type/--icmpv6-type.
Looks good to me.
prev parent reply other threads:[~2006-07-04 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-30 20:18 [PATCH] icmpv6 match --icmpv6-type confusion Phil Oester
2006-07-03 17:52 ` Patrick McHardy
2006-07-04 0:30 ` Yasuyuki KOZAKAI
[not found] ` <200607040030.k640U4e5004273@toshiba.co.jp>
2006-07-04 0:46 ` Patrick McHardy
2006-07-04 4:26 ` Yasuyuki KOZAKAI
[not found] ` <200607040426.k644QCpQ026660@toshiba.co.jp>
2006-07-04 8:21 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AA2520.20006@trash.net \
--to=kaber@trash.net \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.