From: Dirk Behme <dirk.behme@googlemail.com>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] ARM: OMAP: Fix missing channel using omap_set_dma_priority()
Date: Tue, 04 Jul 2006 16:45:23 +0200 [thread overview]
Message-ID: <44AA7F03.7090802@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
ARM: OMAP: Fix missing channel parameter using
omap_set_dma_priority() in omapfb_main.c:
drivers/video/omap/omapfb_main.c: In function 'omapfb_do_probe':
drivers/video/omap/omapfb_main.c:1441: error: too few
arguments to function
'omap_set_dma_priority'
omap_set_dma_priority() in dma.c wants a channel as first
parameter which is missing here. However, this is only used
on OMAP24xx, on OMAP1 it isn't. Therefore I don't know if 0
is correct here, it's
don't care for OMAP1. Please check.
Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
[-- Attachment #2: dma_priority_workaround_patch.txt --]
[-- Type: text/plain, Size: 503 bytes --]
--- ./drivers/video/omap/omapfb_main.c_orig 2006-07-04 16:28:26.000000000 +0200
+++ ./drivers/video/omap/omapfb_main.c 2006-07-04 16:34:25.000000000 +0200
@@ -1438,7 +1438,7 @@ static int omapfb_do_probe(struct platfo
#ifdef CONFIG_FB_OMAP_DMA_TUNE
/* Set DMA priority for EMIFF access to highest */
if (cpu_class_is_omap1())
- omap_set_dma_priority(OMAP_DMA_PORT_EMIFF, 15);
+ omap_set_dma_priority(0, OMAP_DMA_PORT_EMIFF, 15);
#endif
r = ctrl_change_mode(fbdev->fb_info[0]);
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
reply other threads:[~2006-07-04 14:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AA7F03.7090802@gmail.com \
--to=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.