From: Jan Kiszka <jan.kiszka@domain.hid>
To: Antoine.BRUGEAS@fr.thalesgroup.com
Cc: Xenomai-help@domain.hid
Subject: Re: [Xenomai-help] Modification of the PSOS skin. [update]
Date: Wed, 05 Jul 2006 14:09:07 +0200 [thread overview]
Message-ID: <44ABABE3.6070600@domain.hid> (raw)
In-Reply-To: <FB64A9A42E10824EAC3F78D6A2CD596E04DBD14D@kheops.clb.tcfr.thales>
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
Antoine.BRUGEAS@fr.thalesgroup.com wrote:
> Result of the diff command :
[skipping and acknowledging what Romain already remarked]
Your patch is small, so manual fixing during merge is no big issue here.
But for larger patches a cleanup would be good, i.e. removing of dead
code etc.
And for crediting your work you may provide a patch for ChangeLog
(instead of the adding this as comment to the code). If not we would add
it on commit.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]
next prev parent reply other threads:[~2006-07-05 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 11:46 [Xenomai-help] Modification of the PSOS skin. [update] Antoine.BRUGEAS
2006-07-05 12:02 ` Romain Lenglet
2006-07-05 12:09 ` Jan Kiszka [this message]
2006-07-05 12:25 ` Romain Lenglet
2006-07-06 11:35 ` [Xenomai-core] " Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44ABABE3.6070600@domain.hid \
--to=jan.kiszka@domain.hid \
--cc=Antoine.BRUGEAS@fr.thalesgroup.com \
--cc=Xenomai-help@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.