From: Avi Kivity <avi@argo.co.il>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Duncan Sands <duncan.sands@math.u-psud.fr>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>,
chas@cmf.nrl.navy.mil
Subject: Re: possible recursive locking in ATM layer
Date: Wed, 05 Jul 2006 16:33:11 +0300 [thread overview]
Message-ID: <44ABBF97.3070709@argo.co.il> (raw)
In-Reply-To: <1152029582.3109.70.camel@laptopd505.fenrus.org>
Arjan van de Ven wrote:
>
> From: Arjan van de Ven <arjan@linux.intel.com>
>
> > Linux version 2.6.17-git22 (duncan@baldrick) (gcc version 4.0.3
> (Ubuntu 4.0.3-1ubuntu5)) #20 PREEMPT Tue Jul 4 10:35:04 CEST 2006
>
> >
> > [ 2381.598609] =============================================
> > [ 2381.619314] [ INFO: possible recursive locking detected ]
> > [ 2381.635497] ---------------------------------------------
> > [ 2381.651706] atmarpd/2696 is trying to acquire lock:
> > [ 2381.666354] (&skb_queue_lock_key){-+..}, at: [<c028c540>]
> skb_migrate+0x24/0x6c
> > [ 2381.688848]
>
>
> ok this is a real potential deadlock in a way, it takes two locks of 2
> skbuffs without doing any kind of lock ordering; I think the following
> patch should fix it. Just sort the lock taking order by address of the
> skb.. it's not pretty but it's the best this can do in a minimally
> invasive way.
>
Isn't it a deadlock only if skb_migrate(a, b) and skb_migrate(b, a) can
be called concurrently?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2006-07-05 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 15:59 possible recursive locking in ATM layer Duncan Sands
2006-07-04 16:13 ` Arjan van de Ven
2006-07-05 10:23 ` Duncan Sands
2006-07-05 13:33 ` Avi Kivity [this message]
2006-07-05 13:42 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44ABBF97.3070709@argo.co.il \
--to=avi@argo.co.il \
--cc=arjan@infradead.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=duncan.sands@math.u-psud.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.