[PATCH] please kill santa-claus

[PATCH] please kill santa-claus

[Pierre-Yves Ritschard]

Hi,

While running our home-brewed firewall scripts the output was broken by
a weird message spewed by the libipt_iprange extension:
	"hoho" (sic)
I wonder why that is, it seems not too many people noticed or use
src-range inversion which is the feature that triggers this friendly yet
surprising message.
If there's a specific reason (which I haven't found in TFA or google)
please let me know, otherwise please consider this one-liner:

--- extensions/libipt_iprange.c.orig    Fri Jun 30 17:34:05 2006
+++ extensions/libipt_iprange.c Fri Jun 30 17:34:21 2006
@@ -73,7 +73,6 @@
                check_inverse(optarg, &invert, &optind, 0);
                if (invert) {
                        info->flags |= IPRANGE_SRC_INV;
-                       printf("hoho\n");
                }
                parse_iprange(optarg, &info->src);              
 

Thanks for your time,
pyr

Re: [PATCH] please kill santa-claus

[Patrick McHardy]

Pierre-Yves Ritschard wrote:
> While running our home-brewed firewall scripts the output was broken by
> a weird message spewed by the libipt_iprange extension:
> 	"hoho" (sic)
> I wonder why that is, it seems not too many people noticed or use
> src-range inversion which is the feature that triggers this friendly yet
> surprising message.
> If there's a specific reason (which I haven't found in TFA or google)
> please let me know, otherwise please consider this one-liner:
> 
> --- extensions/libipt_iprange.c.orig    Fri Jun 30 17:34:05 2006
> +++ extensions/libipt_iprange.c Fri Jun 30 17:34:21 2006
> @@ -73,7 +73,6 @@
>                 check_inverse(optarg, &invert, &optind, 0);
>                 if (invert) {
>                         info->flags |= IPRANGE_SRC_INV;
> -                       printf("hoho\n");
>                 }
>                 parse_iprange(optarg, &info->src);              

LOL :) Applied, thanks.

Re: [PATCH] please kill santa-claus

[Pablo Neira Ayuso]

Patrick McHardy wrote:
> Pierre-Yves Ritschard wrote:
> 
>>While running our home-brewed firewall scripts the output was broken by
>>a weird message spewed by the libipt_iprange extension:
>>	"hoho" (sic)
>>I wonder why that is, it seems not too many people noticed or use
>>src-range inversion which is the feature that triggers this friendly yet
>>surprising message.
>>If there's a specific reason (which I haven't found in TFA or google)
>>please let me know, otherwise please consider this one-liner:
>>
>>--- extensions/libipt_iprange.c.orig    Fri Jun 30 17:34:05 2006
>>+++ extensions/libipt_iprange.c Fri Jun 30 17:34:21 2006
>>@@ -73,7 +73,6 @@
>>                check_inverse(optarg, &invert, &optind, 0);
>>                if (invert) {
>>                        info->flags |= IPRANGE_SRC_INV;
>>-                       printf("hoho\n");
>>                }
>>                parse_iprange(optarg, &info->src);              
> 
> 
> LOL :) Applied, thanks.

This is Jozsef's :D

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of 
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

Re: [PATCH] please kill santa-claus

[Jozsef Kadlecsik]

On Wed, 5 Jul 2006, Pablo Neira Ayuso wrote:

> Patrick McHardy wrote:
> > Pierre-Yves Ritschard wrote:
> >
> >>While running our home-brewed firewall scripts the output was broken by
> >>a weird message spewed by the libipt_iprange extension:
> >>	"hoho" (sic)
> >>I wonder why that is, it seems not too many people noticed or use
> >>src-range inversion which is the feature that triggers this friendly yet
> >>surprising message.
> >>If there's a specific reason (which I haven't found in TFA or google)
> >>please let me know, otherwise please consider this one-liner:
> >>
> >>--- extensions/libipt_iprange.c.orig    Fri Jun 30 17:34:05 2006
> >>+++ extensions/libipt_iprange.c Fri Jun 30 17:34:21 2006
> >>@@ -73,7 +73,6 @@
> >>                check_inverse(optarg, &invert, &optind, 0);
> >>                if (invert) {
> >>                        info->flags |= IPRANGE_SRC_INV;
> >>-                       printf("hoho\n");
> >>                }
> >>                parse_iprange(optarg, &info->src);
> >
> >
> > LOL :) Applied, thanks.
>
> This is Jozsef's :D

Yes, that's from me: I'm surprised the (probably :-) debug message could
survive unnoticed so long.

The cryptic word means 'whoa!' approximately in Hungarian :-).

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@sunserv.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary